* [PATCH 1/1] NFS: Don't specify NFS version in "UDP not supported" error
@ 2020-03-24 20:08 Petr Vorel
0 siblings, 0 replies; only message in thread
From: Petr Vorel @ 2020-03-24 20:08 UTC (permalink / raw)
To: linux-nfs
Cc: Petr Vorel, Olga Kornievskaia, Anna Schumaker, Trond Myklebust,
J . Bruce Fields, Chuck Lever
UDP was originally disabled in 6da1a034362f for NFSv4. Later in
b24ee6c64ca7 UDP is by default disabled by NFS_DISABLE_UDP_SUPPORT=y for
all NFS versions. Therefore remove v4 from error message.
Fixes: b24ee6c64ca7 ("NFS: allow deprecation of NFS UDP protocol")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
although on NFS_DISABLE_UDP_SUPPORT=n it might be confusing that
version is not specified, IMHO it's less confusing than "NFSv4" for
NFSv3. But if you like I can distinguish these two cases.
Kind regards,
Petr
fs/nfs/fs_context.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c
index e113fcb4bb4c..566dd59570e6 100644
--- a/fs/nfs/fs_context.c
+++ b/fs/nfs/fs_context.c
@@ -1135,7 +1135,7 @@ static int nfs4_parse_monolithic(struct fs_context *fc,
return nfs_invalf(fc, "NFS4: mount program didn't pass remote address");
out_invalid_transport_udp:
- return nfs_invalf(fc, "NFSv4: Unsupported transport protocol udp");
+ return nfs_invalf(fc, "NFS: Unsupported transport protocol udp");
}
#endif
@@ -1257,7 +1257,7 @@ static int nfs_fs_context_validate(struct fs_context *fc)
nfs_errorf(fc, "NFS: NFSv4 is not compiled into kernel");
return -EPROTONOSUPPORT;
out_invalid_transport_udp:
- return nfs_invalf(fc, "NFSv4: Unsupported transport protocol udp");
+ return nfs_invalf(fc, "NFS: Unsupported transport protocol udp");
out_no_address:
return nfs_invalf(fc, "NFS: mount program didn't pass remote address");
out_mountproto_mismatch:
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-24 20:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 20:08 [PATCH 1/1] NFS: Don't specify NFS version in "UDP not supported" error Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).