* Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) [not found] <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> @ 2020-07-21 15:14 ` Russell King - ARM Linux admin 2020-07-21 15:18 ` Chuck Lever 0 siblings, 1 reply; 2+ messages in thread From: Russell King - ARM Linux admin @ 2020-07-21 15:14 UTC (permalink / raw) To: Chuck Lever; +Cc: linux-arm-kernel, linux-nfs A build of my tree by Olof's autobuilder revealed a problem concerning a couple of platforms - this is based on v5.8-rc3: On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote: > arm.mps2_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > > arm.xcep_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] The issue is that as the #if concerned is used to determine whether code that calls flush_dcache_page() (and therefore ensures data integrity) is omitted - and in the above cases it will be omitted. On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in asm/cacheflush.h, but for some reason, it seems that net/sunrpc/svcsock.c is not seeing that. Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to ensure it picks up the definition of this preprocessor symbol? It looks like this was introduced by: commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8 Author: Chuck Lever <chuck.lever@oracle.com> Date: Wed May 20 17:30:12 2020 -0400 SUNRPC: Refactor svc_recvfrom() Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) 2020-07-21 15:14 ` rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) Russell King - ARM Linux admin @ 2020-07-21 15:18 ` Chuck Lever 0 siblings, 0 replies; 2+ messages in thread From: Chuck Lever @ 2020-07-21 15:18 UTC (permalink / raw) To: Russell King - ARM Linux admin; +Cc: linux-arm-kernel, Linux NFS Mailing List Hi Russell- > On Jul 21, 2020, at 11:14 AM, Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > > A build of my tree by Olof's autobuilder revealed a problem concerning > a couple of platforms - this is based on v5.8-rc3: > > On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote: >> arm.mps2_defconfig: >> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] >> >> arm.xcep_defconfig: >> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] >> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > > The issue is that as the #if concerned is used to determine whether > code that calls flush_dcache_page() (and therefore ensures data > integrity) is omitted - and in the above cases it will be omitted. > > On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in > asm/cacheflush.h, but for some reason, it seems that > net/sunrpc/svcsock.c is not seeing that. > > Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to > ensure it picks up the definition of this preprocessor symbol? > > It looks like this was introduced by: > > commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8 > Author: Chuck Lever <chuck.lever@oracle.com> > Date: Wed May 20 17:30:12 2020 -0400 > > SUNRPC: Refactor svc_recvfrom() > > Thanks. This should be addressed by becd2014923f ("SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE") which was merged in v5.8-rc4. -- Chuck Lever ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 15:20 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> 2020-07-21 15:14 ` rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) Russell King - ARM Linux admin 2020-07-21 15:18 ` Chuck Lever
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).