From: "bfields@fieldses.org" <bfields@fieldses.org>
To: dai.ngo@oracle.com
Cc: Trond Myklebust <trondmy@hammerspace.com>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v5 0/2] nfsd: Initial implementation of NFSv4 Courteous Server
Date: Wed, 1 Dec 2021 09:19:22 -0500 [thread overview]
Message-ID: <20211201141922.GA24991@fieldses.org> (raw)
In-Reply-To: <9cfd81cc-aee9-bcf3-a4be-bb9a39992ae8@oracle.com>
On Tue, Nov 30, 2021 at 07:52:10PM -0800, dai.ngo@oracle.com wrote:
> On 11/30/21 5:37 AM, Trond Myklebust wrote:
> >Then kick off a thread or work item to do that asynchronously in the
> >background, and return NFS4ERR_DELAY to the clients that were trying to
> >grab locks in the meantime.
>
> Thanks Trond, I think this is a reasonable approach. The behavior would
> be similar to a delegation recall during the OPEN.
>
> My plan is:
>
> 1. If the number of conflict clients is less than 100 (some numbers that
> cover realistic usage) then release all their state synchronously in
> the OPEN call, and returns NFS4_OK to the NFS client. Most of conflicts
> should be handled by this case.
>
> 2. If the number of conflict clients is more than 100 then release the
> state of the 1st 100 clients as in (1) and trigger the laundromat thread
> to release state of the rest of the conflict clients, and return
> NFS4ERR_DELAY to the NFS client. This should be a rare condition.
Honestly, conflict with a courtesy client is itself not going to be that
common, so personally I'd start simple and handle everything with the
asynchronous approach.
--b.
next prev parent reply other threads:[~2021-12-01 14:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 0:56 [PATCH RFC v5 0/2] nfsd: Initial implementation of NFSv4 Courteous Server Dai Ngo
2021-09-29 0:56 ` [PATCH RFC v5 1/2] fs/lock: add new callback, lm_expire_lock, to lock_manager_operations Dai Ngo
2021-09-29 0:56 ` [PATCH RFC v5 2/2] nfsd: Initial implementation of NFSv4 Courteous Server Dai Ngo
2021-10-01 20:53 ` [PATCH RFC v5 0/2] " J. Bruce Fields
2021-10-01 21:41 ` dai.ngo
2021-10-01 23:03 ` J. Bruce Fields
2021-11-16 23:06 ` dai.ngo
2021-11-17 14:14 ` J. Bruce Fields
2021-11-17 17:59 ` dai.ngo
2021-11-17 21:46 ` dai.ngo
2021-11-18 0:34 ` J. Bruce Fields
2021-11-22 3:04 ` dai.ngo
2021-11-29 17:13 ` dai.ngo
2021-11-29 17:30 ` J. Bruce Fields
2021-11-29 18:32 ` dai.ngo
2021-11-29 19:03 ` Chuck Lever III
2021-11-29 19:13 ` Bruce Fields
2021-11-29 19:39 ` dai.ngo
2021-11-29 19:36 ` dai.ngo
2021-11-29 21:01 ` dai.ngo
2021-11-29 21:10 ` Chuck Lever III
2021-11-30 0:11 ` dai.ngo
2021-11-30 1:42 ` Chuck Lever III
2021-11-30 4:08 ` Trond Myklebust
2021-11-30 4:47 ` Chuck Lever III
2021-11-30 4:57 ` Trond Myklebust
2021-11-30 7:22 ` dai.ngo
2021-11-30 13:37 ` Trond Myklebust
2021-12-01 3:52 ` dai.ngo
2021-12-01 14:19 ` bfields [this message]
2021-11-30 15:36 ` Chuck Lever III
2021-11-30 16:05 ` Bruce Fields
2021-11-30 16:14 ` Trond Myklebust
2021-11-30 19:01 ` bfields
2021-11-30 7:13 ` dai.ngo
2021-11-30 15:32 ` Bruce Fields
2021-12-01 3:50 ` dai.ngo
2021-12-01 14:36 ` Bruce Fields
2021-12-01 14:51 ` Bruce Fields
2021-12-01 18:47 ` dai.ngo
2021-12-01 19:25 ` Bruce Fields
2021-12-02 17:53 ` Chuck Lever III
2021-12-01 17:42 ` Bruce Fields
2021-12-01 18:03 ` Bruce Fields
2021-12-01 19:50 ` Bruce Fields
2021-12-03 21:22 ` Bruce Fields
2021-12-03 21:55 ` [PATCH] nfsdcld: use WAL journal for faster commits Bruce Fields
2021-12-03 22:07 ` Chuck Lever III
2021-12-03 22:39 ` Bruce Fields
2021-12-04 0:35 ` Chuck Lever III
2021-12-04 1:24 ` Bruce Fields
2021-12-06 15:46 ` Chuck Lever III
2022-01-04 22:24 ` Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201141922.GA24991@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).