* [PATCH] nfs-utils: remove leftover debugging messages
@ 2020-10-29 21:18 Holger Hoffstätte
2020-10-31 16:24 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Holger Hoffstätte @ 2020-10-29 21:18 UTC (permalink / raw)
To: linux-nfs; +Cc: Steve Dickson
After updating to nfs-utils-2.5.2 I noticed extra output on the console
when exporting mounts. Apparently commit 482e72ba04 forgot to remove some
debugging messages and accidentally committed them.
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
---
support/misc/nfsd_path.c | 2 +-
utils/exportfs/exportfs.c | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/support/misc/nfsd_path.c b/support/misc/nfsd_path.c
index 8efbfcd3..65e53c13 100644
--- a/support/misc/nfsd_path.c
+++ b/support/misc/nfsd_path.c
@@ -110,7 +110,7 @@ nfsd_setup_workqueue(void)
if (!rootdir)
return;
-printf("rootdir %s\n", rootdir);
+
nfsd_wq = xthread_workqueue_alloc();
if (!nfsd_wq)
return;
diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index 9d5e575b..cde5e517 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -176,10 +176,8 @@ main(int argc, char **argv)
xlog(L_ERROR, "-r and -u are incompatible");
return 1;
}
-printf("point 1\n");
if (!setup_state_path_names(progname, ETAB, ETABTMP, ETABLCK, &etab))
return 1;
-printf("point 2\n");
if (optind == argc && ! f_all) {
if (force_flush) {
cache_flush(1);
@@ -193,7 +191,6 @@ printf("point 2\n");
return 0;
}
}
-printf("point 3\n");
/*
* Serialize things as best we can
--
2.29.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs-utils: remove leftover debugging messages
2020-10-29 21:18 [PATCH] nfs-utils: remove leftover debugging messages Holger Hoffstätte
@ 2020-10-31 16:24 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2020-10-31 16:24 UTC (permalink / raw)
To: Holger Hoffstätte, linux-nfs
On 10/29/20 5:18 PM, Holger Hoffstätte wrote:
>
> After updating to nfs-utils-2.5.2 I noticed extra output on the console
> when exporting mounts. Apparently commit 482e72ba04 forgot to remove some
> debugging messages and accidentally committed them.
>
> Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
WOW! I did skip a beat on this one! Thanks for the clean up!!!
Committed!
steved.
> ---
> support/misc/nfsd_path.c | 2 +-
> utils/exportfs/exportfs.c | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/support/misc/nfsd_path.c b/support/misc/nfsd_path.c
> index 8efbfcd3..65e53c13 100644
> --- a/support/misc/nfsd_path.c
> +++ b/support/misc/nfsd_path.c
> @@ -110,7 +110,7 @@ nfsd_setup_workqueue(void)
>
> if (!rootdir)
> return;
> -printf("rootdir %s\n", rootdir);
> +
> nfsd_wq = xthread_workqueue_alloc();
> if (!nfsd_wq)
> return;
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 9d5e575b..cde5e517 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -176,10 +176,8 @@ main(int argc, char **argv)
> xlog(L_ERROR, "-r and -u are incompatible");
> return 1;
> }
> -printf("point 1\n");
> if (!setup_state_path_names(progname, ETAB, ETABTMP, ETABLCK, &etab))
> return 1;
> -printf("point 2\n");
> if (optind == argc && ! f_all) {
> if (force_flush) {
> cache_flush(1);
> @@ -193,7 +191,6 @@ printf("point 2\n");
> return 0;
> }
> }
> -printf("point 3\n");
>
> /*
> * Serialize things as best we can
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-31 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 21:18 [PATCH] nfs-utils: remove leftover debugging messages Holger Hoffstätte
2020-10-31 16:24 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).