* [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/
@ 2020-03-19 15:30 J. Bruce Fields
2020-03-19 15:35 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: J. Bruce Fields @ 2020-03-19 15:30 UTC (permalink / raw)
To: Chuck Lever; +Cc: linux-nfs
From: "J. Bruce Fields" <bfields@redhat.com>
Userspace should be able to monitor nfsd/clients/ to see when clients
come and go, but we're failing to send fsnotify events.
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/nfsd/nfsctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index e109a1007704..3bb2db947d29 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -1333,6 +1333,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
dget(dentry);
ret = simple_rmdir(dir, dentry);
WARN_ON_ONCE(ret);
+ fsnotify_rmdir(dir, dentry);
d_delete(dentry);
inode_unlock(dir);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/
2020-03-19 15:30 [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/ J. Bruce Fields
@ 2020-03-19 15:35 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2020-03-19 15:35 UTC (permalink / raw)
To: Bruce Fields; +Cc: Linux NFS Mailing List
> On Mar 19, 2020, at 11:30 AM, bfields@fieldses.org wrote:
>
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> Userspace should be able to monitor nfsd/clients/ to see when clients
> come and go, but we're failing to send fsnotify events.
>
> Cc: stable@kernel.org
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Applied to nfsd-5.7, thanks!
> ---
> fs/nfsd/nfsctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index e109a1007704..3bb2db947d29 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1333,6 +1333,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
> dget(dentry);
> ret = simple_rmdir(dir, dentry);
> WARN_ON_ONCE(ret);
> + fsnotify_rmdir(dir, dentry);
> d_delete(dentry);
> inode_unlock(dir);
> }
> --
> 2.25.1
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-19 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 15:30 [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/ J. Bruce Fields
2020-03-19 15:35 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).