* [PATCH] nfsd: fix incorrect indentation on goto statement
@ 2017-12-22 0:35 Colin King
2017-12-22 1:11 ` Kinglong Mee
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-12-22 0:35 UTC (permalink / raw)
To: J . Bruce Fields, Jeff Layton, linux-nfs; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The goto statement requires one more level of indentation, add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index b29b5a185a2c..3bb720a59b49 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -6159,7 +6159,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
default:
dprintk("NFSD: nfs4_lockt: bad lock type!\n");
status = nfserr_inval;
- goto out;
+ goto out;
}
lo = find_lockowner_str(cstate->clp, &lockt->lt_owner);
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: fix incorrect indentation on goto statement
2017-12-22 0:35 [PATCH] nfsd: fix incorrect indentation on goto statement Colin King
@ 2017-12-22 1:11 ` Kinglong Mee
0 siblings, 0 replies; 2+ messages in thread
From: Kinglong Mee @ 2017-12-22 1:11 UTC (permalink / raw)
To: Colin King
Cc: J . Bruce Fields, Jeff Layton, Linux NFS Mailing List,
kernel-janitors, linux-kernel
On Fri, Dec 22, 2017 at 8:35 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The goto statement requires one more level of indentation, add it.
Those "break" in this switch need one more level too,
it's nice to add them in this patch.
thanks,
Kinglong Mee
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index b29b5a185a2c..3bb720a59b49 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6159,7 +6159,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> default:
> dprintk("NFSD: nfs4_lockt: bad lock type!\n");
> status = nfserr_inval;
> - goto out;
> + goto out;
> }
>
> lo = find_lockowner_str(cstate->clp, &lockt->lt_owner);
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-22 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22 0:35 [PATCH] nfsd: fix incorrect indentation on goto statement Colin King
2017-12-22 1:11 ` Kinglong Mee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).