* [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP
@ 2019-12-30 15:32 Geert Uytterhoeven
2019-12-30 15:55 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-30 15:32 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, Rik van Riel, Mel Gorman, Andrew Morton
Cc: linux-nfs, linux-mm, linux-kernel, Geert Uytterhoeven
If CONFIG_SWAP=n, it does not make much sense to offer the user the
option to enable support for swapping over NFS, as that will still fail
at run time:
# swapon /swap
swapon: /swap: swapon failed: Function not implemented
Fix this by adding a dependency on CONFIG_SWAP.
Fixes: a564b8f0398636ba ("nfs: enable swap on NFS")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Marked RFC, as this still doesn't seem to work.
When enabled, the kernel log is spammed with:
[ 449.371536] __swap_writepage: 413288 callbacks suppressed
[ 449.371577] Write error on dio swapfile (10047488)
[ 449.382435] Write error on dio swapfile (14147584)
[ 449.387320] Write error on dio swapfile (10919936)
[ 449.392474] Write error on dio swapfile (8945664)
[ 449.397263] Write error on dio swapfile (24256512)
[ 449.402330] Write error on dio swapfile (14307328)
[ 449.407195] Write error on dio swapfile (229376)
[ 449.412031] Write error on dio swapfile (10293248)
[ 449.416891] Write error on dio swapfile (2007040)
Platform is 32-bit Cortex A9 with 32 MiB of RAM (hence the need for
swap).
---
fs/nfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 295a7a21b7744014..e7dd07f47825939e 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -90,7 +90,7 @@ config NFS_V4
config NFS_SWAP
bool "Provide swap over NFS support"
default n
- depends on NFS_FS
+ depends on NFS_FS && SWAP
select SUNRPC_SWAP
help
This option enables swapon to work on files located on NFS mounts.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP
2019-12-30 15:32 [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP Geert Uytterhoeven
@ 2019-12-30 15:55 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-30 15:55 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, Rik van Riel, Mel Gorman, Andrew Morton
Cc: open list:NFS, SUNRPC, AND...,
Linux MM, Linux Kernel Mailing List, Geert Uytterhoeven
On Mon, Dec 30, 2019 at 4:32 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> If CONFIG_SWAP=n, it does not make much sense to offer the user the
> option to enable support for swapping over NFS, as that will still fail
> at run time:
>
> # swapon /swap
> swapon: /swap: swapon failed: Function not implemented
>
> Fix this by adding a dependency on CONFIG_SWAP.
>
> Fixes: a564b8f0398636ba ("nfs: enable swap on NFS")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Marked RFC, as this still doesn't seem to work.
> When enabled, the kernel log is spammed with:
>
> [ 449.371536] __swap_writepage: 413288 callbacks suppressed
> [ 449.371577] Write error on dio swapfile (10047488)
> [ 449.382435] Write error on dio swapfile (14147584)
> [ 449.387320] Write error on dio swapfile (10919936)
> [ 449.392474] Write error on dio swapfile (8945664)
> [ 449.397263] Write error on dio swapfile (24256512)
> [ 449.402330] Write error on dio swapfile (14307328)
> [ 449.407195] Write error on dio swapfile (229376)
> [ 449.412031] Write error on dio swapfile (10293248)
> [ 449.416891] Write error on dio swapfile (2007040)
FWIW, swap over /dev/loop0 using a file on nfsroot also doesn't work: system
hangs, but is still reponsive to ping.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-30 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-30 15:32 [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP Geert Uytterhoeven
2019-12-30 15:55 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).