* [PATCH] NFS: fix ifnullfree.cocci warnings
@ 2019-07-07 16:45 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2019-07-07 16:45 UTC (permalink / raw)
To: Trond Myklebust
Cc: Anna Schumaker, linux-nfs, linux-kernel, linux-nfs, kbuild-all
From: kbuild test robot <lkp@intel.com>
fs/nfs/sysfs.c:125:2-7: WARNING: NULL check before some freeing functions is not needed.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Fixes: bf11fbdb20b3 ("NFS: Add sysfs support for per-container identifier")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
head: c433a7975cfc839906aaa891f68d86ca228f7e43
commit: bf11fbdb20b385157b046ea7781f04d0c62554a3 [30/57] NFS: Add sysfs support for per-container identifier
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
Please take the patch only if it's a positive warning. Thanks!
sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -121,8 +121,7 @@ static void nfs_netns_client_release(str
struct nfs_netns_client,
kobject);
- if (c->identifier)
- kfree(c->identifier);
+ kfree(c->identifier);
kfree(c);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-07 16:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-07 16:45 [PATCH] NFS: fix ifnullfree.cocci warnings Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).