From: Steve Dickson <SteveD@RedHat.com>
To: Salvatore Bonaccorso <carnil@debian.org>, linux-nfs@vger.kernel.org
Cc: NeilBrown <neilb@suse.de>, Scott Mayhew <smayhew@redhat.com>
Subject: Re: [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces
Date: Fri, 17 Jul 2020 09:55:55 -0400 [thread overview]
Message-ID: <c0223681-6ae1-a163-af54-bd560c11b571@RedHat.com> (raw)
In-Reply-To: <20200628092441.81529-1-carnil@debian.org>
On 6/28/20 5:24 AM, Salvatore Bonaccorso wrote:
> Although whitespaces immediately before or after the "=" are ignored,
> removing the extra whitespaces in some of the key=value assignments
> makes the style more consistent.
>
> At least since systemd v242-rc1[1] this has been clarified that
> whitespaces immediately before and after the "=" are allowed.
>
> [1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0
>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Committed... (tag: nfs-utils-2-5-2-rc2)
steved.
> ---
> systemd/nfs-server.service | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 24118d693965..06c1adb71692 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -1,18 +1,18 @@
> [Unit]
> Description=NFS server and services
> DefaultDependencies=no
> -Requires= network.target proc-fs-nfsd.mount
> -Requires= nfs-mountd.service
> +Requires=network.target proc-fs-nfsd.mount
> +Requires=nfs-mountd.service
> Wants=rpcbind.socket network-online.target
> Wants=rpc-statd.service nfs-idmapd.service
> Wants=rpc-statd-notify.service
> Wants=nfsdcld.service
>
> -After= network-online.target local-fs.target
> -After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> -After= nfs-idmapd.service rpc-statd.service
> -After= nfsdcld.service
> -Before= rpc-statd-notify.service
> +After=network-online.target local-fs.target
> +After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> +After=nfs-idmapd.service rpc-statd.service
> +After=nfsdcld.service
> +Before=rpc-statd-notify.service
>
> # GSS services dependencies and ordering
> Wants=auth-rpcgss-module.service
>
prev parent reply other threads:[~2020-07-17 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 9:24 [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces Salvatore Bonaccorso
2020-07-17 13:55 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0223681-6ae1-a163-af54-bd560c11b571@RedHat.com \
--to=steved@redhat.com \
--cc=carnil@debian.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).