Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: "Christian Bartolomäus" <use_v6@aglaz.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mountd: Remove outdated/misleading comment
Date: Thu, 16 Jan 2020 15:49:08 -0500
Message-ID: <c3735526-a8c6-585a-ef28-7e2122f7c406@RedHat.com> (raw)
In-Reply-To: <20200107211914.GE4452@cus>



On 1/7/20 4:19 PM, Christian Bartolomäus wrote:
> It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
> ("mountd: fix mount issue due to comparison with uninitialized uuid") was
> applied back in 2015. The final case of the switch statement no longer ends
> with a 'return true' and the final 'return false' is relevant now.
> 
> Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
Committed... (tag: nfs-utils-2-4-3-rc5)

steved.

> ---
>  utils/mountd/cache.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index e5186c7..8f54e37 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
>  				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
>  					return true;
>  	}
> -	/* Well, unreachable, actually: */
>  	return false;
>  }
> 


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 21:19 Christian Bartolomäus
2020-01-16 20:49 ` Steve Dickson [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3735526-a8c6-585a-ef28-7e2122f7c406@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=use_v6@aglaz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git