From: Steve Dickson <SteveD@RedHat.com>
To: "Christian Bartolomäus" <use_v6@aglaz.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mountd: Remove outdated/misleading comment
Date: Thu, 16 Jan 2020 15:49:08 -0500 [thread overview]
Message-ID: <c3735526-a8c6-585a-ef28-7e2122f7c406@RedHat.com> (raw)
In-Reply-To: <20200107211914.GE4452@cus>
On 1/7/20 4:19 PM, Christian Bartolomäus wrote:
> It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
> ("mountd: fix mount issue due to comparison with uninitialized uuid") was
> applied back in 2015. The final case of the switch statement no longer ends
> with a 'return true' and the final 'return false' is relevant now.
>
> Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
Committed... (tag: nfs-utils-2-4-3-rc5)
steved.
> ---
> utils/mountd/cache.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index e5186c7..8f54e37 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
> if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
> return true;
> }
> - /* Well, unreachable, actually: */
> return false;
> }
>
prev parent reply other threads:[~2020-01-16 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 21:19 [PATCH] mountd: Remove outdated/misleading comment Christian Bartolomäus
2020-01-16 20:49 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3735526-a8c6-585a-ef28-7e2122f7c406@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=use_v6@aglaz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).