[PATCH] mountd: Remove outdated/misleading comment

[PATCH] mountd: Remove outdated/misleading comment

[Christian Bartolomäus]

It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
("mountd: fix mount issue due to comparison with uninitialized uuid") was
applied back in 2015. The final case of the switch statement no longer ends
with a 'return true' and the final 'return false' is relevant now.

Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
---
 utils/mountd/cache.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index e5186c7..8f54e37 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
 				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
 					return true;
 	}
-	/* Well, unreachable, actually: */
 	return false;
 }

Re: [PATCH] mountd: Remove outdated/misleading comment

[Steve Dickson]

On 1/7/20 4:19 PM, Christian Bartolomäus wrote:
> It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
> ("mountd: fix mount issue due to comparison with uninitialized uuid") was
> applied back in 2015. The final case of the switch statement no longer ends
> with a 'return true' and the final 'return false' is relevant now.
> 
> Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
Committed... (tag: nfs-utils-2-4-3-rc5)

steved.

> ---
>  utils/mountd/cache.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index e5186c7..8f54e37 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
>  				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
>  					return true;
>  	}
> -	/* Well, unreachable, actually: */
>  	return false;
>  }
>