Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [nfs-utils PATCH 1/1] mount: Fix return 0 from void function
@ 2019-11-22 16:25 Petr Vorel
  2019-11-22 18:09 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2019-11-22 16:25 UTC (permalink / raw)
  To: linux-nfs; +Cc: Petr Vorel, Steve Dickson

Fixes: d5e30346 ("mount: Do not overwrite /etc/mtab if it's symlink")

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi Steve,

sorry for introducing a regression.

Kind regards,
Petr

 utils/mount/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/mount/mount.c b/utils/mount/mount.c
index 92a0dfe4..2be3dc2f 100644
--- a/utils/mount/mount.c
+++ b/utils/mount/mount.c
@@ -208,7 +208,7 @@ create_mtab (void) {
 	   that would create a file /proc/mounts in case the proc filesystem
 	   is not mounted, and the fchmod below would also fail. */
 	if (mtab_is_a_symlink()) {
-		return EX_SUCCESS;
+		return;
 	}
 
 	lock_mtab();
-- 
2.24.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [nfs-utils PATCH 1/1] mount: Fix return 0 from void function
  2019-11-22 16:25 [nfs-utils PATCH 1/1] mount: Fix return 0 from void function Petr Vorel
@ 2019-11-22 18:09 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2019-11-22 18:09 UTC (permalink / raw)
  To: Petr Vorel, linux-nfs



On 11/22/19 11:25 AM, Petr Vorel wrote:
> Fixes: d5e30346 ("mount: Do not overwrite /etc/mtab if it's symlink")
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Hi Steve,
> 
> sorry for introducing a regression.
No biggie... I should have caught it and I would think the 
compiler should say something... Throw a warning or something.

Committed (tag: nfs-utils-2-4-3-rc2)

steved.

> 
> Kind regards,
> Petr
> 
>  utils/mount/mount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/mount/mount.c b/utils/mount/mount.c
> index 92a0dfe4..2be3dc2f 100644
> --- a/utils/mount/mount.c
> +++ b/utils/mount/mount.c
> @@ -208,7 +208,7 @@ create_mtab (void) {
>  	   that would create a file /proc/mounts in case the proc filesystem
>  	   is not mounted, and the fchmod below would also fail. */
>  	if (mtab_is_a_symlink()) {
> -		return EX_SUCCESS;
> +		return;
>  	}
>  
>  	lock_mtab();
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 16:25 [nfs-utils PATCH 1/1] mount: Fix return 0 from void function Petr Vorel
2019-11-22 18:09 ` Steve Dickson

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git