linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
@ 2021-04-07  7:10 Zou Wei
  2021-04-20  6:35 ` Santosh Sivaraj
  0 siblings, 1 reply; 3+ messages in thread
From: Zou Wei @ 2021-04-07  7:10 UTC (permalink / raw)
  To: dan.j.williams, vishal.l.verma, dave.jiang, ira.weiny
  Cc: linux-nvdimm, linux-kernel, Zou Wei

The sparse tool complains as follows:

tools/testing/nvdimm/test/iomap.c:65:14: warning:
 symbol '__nfit_test_ioremap' was not declared. Should it be static?

This symbol is not used outside of security.c, so this
commit marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 tools/testing/nvdimm/test/iomap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
index c62d372..ed563bd 100644
--- a/tools/testing/nvdimm/test/iomap.c
+++ b/tools/testing/nvdimm/test/iomap.c
@@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
 }
 EXPORT_SYMBOL(get_nfit_res);
 
-void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
+static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
 		void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
 {
 	struct nfit_test_resource *nfit_res = get_nfit_res(offset);
-- 
2.6.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
  2021-04-07  7:10 [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static Zou Wei
@ 2021-04-20  6:35 ` Santosh Sivaraj
  2021-04-20  7:19   ` Samuel Zou
  0 siblings, 1 reply; 3+ messages in thread
From: Santosh Sivaraj @ 2021-04-20  6:35 UTC (permalink / raw)
  To: Zou Wei, dan.j.williams, vishal.l.verma, dave.jiang, ira.weiny
  Cc: linux-nvdimm, linux-kernel, Zou Wei


Hi Zou,

Zou Wei <zou_wei@huawei.com> writes:

> The sparse tool complains as follows:
>
> tools/testing/nvdimm/test/iomap.c:65:14: warning:
>  symbol '__nfit_test_ioremap' was not declared. Should it be static?
>
> This symbol is not used outside of security.c, so this

s/security.c/iomap.c/

Thanks,
Santosh

> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  tools/testing/nvdimm/test/iomap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
> index c62d372..ed563bd 100644
> --- a/tools/testing/nvdimm/test/iomap.c
> +++ b/tools/testing/nvdimm/test/iomap.c
> @@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
>  }
>  EXPORT_SYMBOL(get_nfit_res);
>  
> -void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
> +static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
>  		void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
>  {
>  	struct nfit_test_resource *nfit_res = get_nfit_res(offset);
> -- 
> 2.6.2
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
  2021-04-20  6:35 ` Santosh Sivaraj
@ 2021-04-20  7:19   ` Samuel Zou
  0 siblings, 0 replies; 3+ messages in thread
From: Samuel Zou @ 2021-04-20  7:19 UTC (permalink / raw)
  To: Santosh Sivaraj, dan.j.williams, vishal.l.verma, dave.jiang, ira.weiny
  Cc: linux-nvdimm, linux-kernel

Hi Santosh,

Thanks for your review, and sorry for my mistake. I will send the v2 soon.

On 2021/4/20 14:35, Santosh Sivaraj wrote:
> 
> Hi Zou,
> 
> Zou Wei <zou_wei@huawei.com> writes:
> 
>> The sparse tool complains as follows:
>>
>> tools/testing/nvdimm/test/iomap.c:65:14: warning:
>>   symbol '__nfit_test_ioremap' was not declared. Should it be static?
>>
>> This symbol is not used outside of security.c, so this
> 
> s/security.c/iomap.c/
> 
> Thanks,
> Santosh
> 
>> commit marks it static.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
>>   tools/testing/nvdimm/test/iomap.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
>> index c62d372..ed563bd 100644
>> --- a/tools/testing/nvdimm/test/iomap.c
>> +++ b/tools/testing/nvdimm/test/iomap.c
>> @@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
>>   }
>>   EXPORT_SYMBOL(get_nfit_res);
>>   
>> -void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
>> +static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
>>   		void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
>>   {
>>   	struct nfit_test_resource *nfit_res = get_nfit_res(offset);
>> -- 
>> 2.6.2
>> _______________________________________________
>> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
>> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
> .
> 
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-20  7:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07  7:10 [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static Zou Wei
2021-04-20  6:35 ` Santosh Sivaraj
2021-04-20  7:19   ` Samuel Zou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).