From: Yi Zhang <yi.z.zhang@linux.intel.com>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: dan.j.williams@intel.com, pbonzini@redhat.com, brho@google.com,
kvm@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, yu.c.zhang@intel.com, pagupta@redhat.com,
david@redhat.com, jack@suse.cz, hch@lst.de, rkrcmar@redhat.com,
jglisse@redhat.com
Subject: Re: [PATCH RFC 0/3] Fix KVM misinterpreting Reserved page as an MMIO page
Date: Tue, 4 Dec 2018 14:59:15 +0800 [thread overview]
Message-ID: <20181204065914.GB73736@tiger-server> (raw)
In-Reply-To: <154386493754.27193.1300965403157243427.stgit@ahduyck-desk1.amr.corp.intel.com>
On 2018-12-03 at 11:25:20 -0800, Alexander Duyck wrote:
> I have loosely based this patch series off of the following patch series
> from Zhang Yi:
> https://lore.kernel.org/lkml/cover.1536342881.git.yi.z.zhang@linux.intel.com
>
> The original set had attempted to address the fact that DAX pages were
> treated like MMIO pages which had resulted in reduced performance. It
> attempted to address this by ignoring the PageReserved flag if the page
> was either a DEV_DAX or FS_DAX page.
>
> I am proposing this as an alternative to that set. The main reason for this
> is because I believe there are a few issues that were overlooked with that
> original set. Specifically KVM seems to have two different uses for the
> PageReserved flag. One being whether or not we can pin the memory, the other
> being if we should be marking the pages as dirty or accessed. I believe
> only the pinning really applies so I have split the uses of
> kvm_is_reserved_pfn and updated the function uses to determine support for
> page pinning to include a check of the pgmap to see if it supports pinning.
kvm is not the only one users of the dax page.
A similar user of PageReserved to look at is:
drivers/vfio/vfio_iommu_type1.c:is_invalid_reserved_pfn(
vfio is also want to know the page is capable for pinning.
I throught that you have removed the reserved flag on the dax page
in https://patchwork.kernel.org/patch/10707267/
is something I missing here?
>
> ---
>
> Alexander Duyck (3):
> kvm: Split use cases for kvm_is_reserved_pfn to kvm_is_refcounted_pfn
> mm: Add support for exposing if dev_pagemap supports refcount pinning
> kvm: Add additional check to determine if a page is refcounted
>
>
> arch/x86/kvm/mmu.c | 6 +++---
> drivers/nvdimm/pfn_devs.c | 2 ++
> include/linux/kvm_host.h | 2 +-
> include/linux/memremap.h | 5 ++++-
> include/linux/mm.h | 11 +++++++++++
> virt/kvm/kvm_main.c | 34 +++++++++++++++++++++++++---------
> 6 files changed, 46 insertions(+), 14 deletions(-)
>
> --
next prev parent reply other threads:[~2018-12-04 6:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 19:25 [PATCH RFC 0/3] Fix KVM misinterpreting Reserved page as an MMIO page Alexander Duyck
2018-12-03 19:25 ` [PATCH RFC 1/3] kvm: Split use cases for kvm_is_reserved_pfn to kvm_is_refcounted_pfn Alexander Duyck
2018-12-03 19:25 ` [PATCH RFC 2/3] mm: Add support for exposing if dev_pagemap supports refcount pinning Alexander Duyck
2018-12-03 19:47 ` Dan Williams
2018-12-03 20:21 ` Alexander Duyck
2018-12-03 20:31 ` Dan Williams
2018-12-03 20:53 ` Alexander Duyck
2018-12-03 21:05 ` Dan Williams
2018-12-03 21:50 ` Alexander Duyck
2018-12-04 19:08 ` Dan Williams
2018-12-04 22:51 ` Alexander Duyck
2018-12-04 23:24 ` Barret Rhoden
2018-12-05 0:01 ` Alexander Duyck
2018-12-05 0:26 ` Dan Williams
2018-12-05 8:13 ` David Hildenbrand
2018-12-03 19:25 ` [PATCH RFC 3/3] kvm: Add additional check to determine if a page is refcounted Alexander Duyck
2018-12-04 6:59 ` Yi Zhang [this message]
2018-12-04 18:45 ` [PATCH RFC 0/3] Fix KVM misinterpreting Reserved page as an MMIO page Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204065914.GB73736@tiger-server \
--to=yi.z.zhang@linux.intel.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).