From: Vishal Verma <vishal.l.verma@intel.com>
To: linux-nvdimm@lists.01.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>
Subject: [ndctl PATCH v7 12/13] contrib/ndctl: add bash-completion for the new daxctl commands
Date: Wed, 24 Jul 2019 15:57:40 -0600 [thread overview]
Message-ID: <20190724215741.18556-13-vishal.l.verma@intel.com> (raw)
In-Reply-To: <20190724215741.18556-1-vishal.l.verma@intel.com>
Add bash completion helpers for the new daxctl-reconfigure-device,
daxctl-online-memory, and daxctl-offline-memory commands.
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
contrib/ndctl | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/contrib/ndctl b/contrib/ndctl
index cacee2d..680fe6a 100755
--- a/contrib/ndctl
+++ b/contrib/ndctl
@@ -547,7 +547,7 @@ __daxctlcomp()
COMPREPLY=( $( compgen -W "$1" -- "$2" ) )
for cword in "${COMPREPLY[@]}"; do
- if [[ "$cword" == @(--region|--dev) ]]; then
+ if [[ "$cword" == @(--region|--dev|--mode) ]]; then
COMPREPLY[$i]="${cword}="
else
COMPREPLY[$i]="${cword} "
@@ -572,6 +572,9 @@ __daxctl_comp_options()
--dev)
opts="$(__daxctl_get_devs -i)"
;;
+ --mode)
+ opts="system-ram devdax"
+ ;;
*)
return
;;
@@ -582,8 +585,23 @@ __daxctl_comp_options()
__daxctl_comp_non_option_args()
{
- # there aren't any commands that accept non option arguments yet
- return
+ local subcmd=$1
+ local cur=$2
+ local opts
+
+ case $subcmd in
+ reconfigure-device)
+ ;&
+ online-memory)
+ ;&
+ offline-memory)
+ opts="$(__daxctl_get_devs -i) all"
+ ;;
+ *)
+ return
+ ;;
+ esac
+ __daxctlcomp "$opts" "$cur"
}
__daxctl_main()
--
2.20.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-07-24 22:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 21:57 [ndctl PATCH v7 00/13] daxctl: add a new reconfigure-device command Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 01/13] libdaxctl: add interfaces to get ctx and check device state Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 02/13] libdaxctl: add interfaces to enable/disable devices Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 03/13] libdaxctl: add an interface to retrieve the device resource Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 04/13] libdaxctl: add a 'daxctl_memory' object for memory based operations Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 05/13] daxctl/list: add target_node for device listings Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 06/13] daxctl/list: display the mode for a dax device Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 07/13] daxctl: add a new reconfigure-device command Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 08/13] Documentation/daxctl: add a man page for daxctl-reconfigure-device Vishal Verma
2019-07-26 2:46 ` Dan Williams
2019-07-26 23:14 ` Verma, Vishal L
2019-07-24 21:57 ` [ndctl PATCH v7 09/13] daxctl: add commands to online and offline memory Vishal Verma
2019-07-26 2:51 ` Dan Williams
2019-07-26 23:15 ` Verma, Vishal L
2019-07-24 21:57 ` [ndctl PATCH v7 10/13] Documentation: Add man pages for daxctl-{on, off}line-memory Vishal Verma
2019-07-26 2:52 ` Dan Williams
2019-07-24 21:57 ` [ndctl PATCH v7 11/13] contrib/ndctl: fix region-id completions for daxctl Vishal Verma
2019-07-26 2:55 ` Dan Williams
2019-07-26 23:30 ` Verma, Vishal L
2019-07-26 23:44 ` Dan Williams
2019-07-24 21:57 ` Vishal Verma [this message]
2019-07-26 2:56 ` [ndctl PATCH v7 12/13] contrib/ndctl: add bash-completion for the new daxctl commands Dan Williams
2019-07-24 21:57 ` [ndctl PATCH v7 13/13] test: Add a unit test for daxctl-reconfigure-device and friends Vishal Verma
2019-07-26 3:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724215741.18556-13-vishal.l.verma@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).