From: Dan Williams <dan.j.williams@intel.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH v7 11/13] contrib/ndctl: fix region-id completions for daxctl
Date: Fri, 26 Jul 2019 16:44:58 -0700 [thread overview]
Message-ID: <CAPcyv4gO=mOkW1b8_MLqs=AuYgopNA1njtaFikvKuNh1-uLb8Q@mail.gmail.com> (raw)
In-Reply-To: <a6ca723887fab20429929217baa08ae26513eb26.camel@intel.com>
On Fri, Jul 26, 2019 at 4:30 PM Verma, Vishal L
<vishal.l.verma@intel.com> wrote:
>
>
> On Thu, 2019-07-25 at 19:55 -0700, Dan Williams wrote:
> > On Wed, Jul 24, 2019 at 2:58 PM Vishal Verma <vishal.l.verma@intel.com
> > > wrote:
> > > The completion helpers for daxctl assumed the region arguments for
> > > specifying daxctl regions were the same as ndctl regions, i.e.
> > > "regionX". This is not true - daxctl region arguments are a simple
> > > numeric 'id'.
> >
> > Oh, that's an unfortunate difference, but too late to change now I
> > think, good find.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Yep - though I think I like --region=0 better than --region=region0,
> less redundancy. But agreed, probably too late to change.
We could teach it to allow both. Something for the backlog, but at
least the kernel is using a common number allocator for pmem regions
and hmem regions.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-07-26 23:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 21:57 [ndctl PATCH v7 00/13] daxctl: add a new reconfigure-device command Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 01/13] libdaxctl: add interfaces to get ctx and check device state Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 02/13] libdaxctl: add interfaces to enable/disable devices Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 03/13] libdaxctl: add an interface to retrieve the device resource Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 04/13] libdaxctl: add a 'daxctl_memory' object for memory based operations Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 05/13] daxctl/list: add target_node for device listings Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 06/13] daxctl/list: display the mode for a dax device Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 07/13] daxctl: add a new reconfigure-device command Vishal Verma
2019-07-24 21:57 ` [ndctl PATCH v7 08/13] Documentation/daxctl: add a man page for daxctl-reconfigure-device Vishal Verma
2019-07-26 2:46 ` Dan Williams
2019-07-26 23:14 ` Verma, Vishal L
2019-07-24 21:57 ` [ndctl PATCH v7 09/13] daxctl: add commands to online and offline memory Vishal Verma
2019-07-26 2:51 ` Dan Williams
2019-07-26 23:15 ` Verma, Vishal L
2019-07-24 21:57 ` [ndctl PATCH v7 10/13] Documentation: Add man pages for daxctl-{on, off}line-memory Vishal Verma
2019-07-26 2:52 ` Dan Williams
2019-07-24 21:57 ` [ndctl PATCH v7 11/13] contrib/ndctl: fix region-id completions for daxctl Vishal Verma
2019-07-26 2:55 ` Dan Williams
2019-07-26 23:30 ` Verma, Vishal L
2019-07-26 23:44 ` Dan Williams [this message]
2019-07-24 21:57 ` [ndctl PATCH v7 12/13] contrib/ndctl: add bash-completion for the new daxctl commands Vishal Verma
2019-07-26 2:56 ` Dan Williams
2019-07-24 21:57 ` [ndctl PATCH v7 13/13] test: Add a unit test for daxctl-reconfigure-device and friends Vishal Verma
2019-07-26 3:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gO=mOkW1b8_MLqs=AuYgopNA1njtaFikvKuNh1-uLb8Q@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=pasha.tatashin@soleen.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).