Re: [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT

From: Dan Williams <dan.j.williams@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT
Date: Fri, 14 Feb 2020 08:13:59 -0800	[thread overview]
Message-ID: <CAPcyv4g7kPtuZ4Cix_4eTVX6p-oK3BsNkCkLmn1h=yhcrMYJ8A@mail.gmail.com> (raw)
In-Reply-To: <20200213205843.GA6600@quack2.suse.cz>

On Fri, Feb 14, 2020 at 1:42 AM Jan Kara <jack@suse.cz> wrote:
>
> On Wed 12-02-20 12:49:41, Dan Williams wrote:
> > On Wed, Feb 12, 2020 at 6:04 AM Jeff Moyer <jmoyer@redhat.com> wrote:
> > >
> > > Jan Kara <jack@suse.cz> writes:
> > >
> > > > When a kernel is configured without CONFIG_DEV_DAX_PMEM_COMPAT, the
> > > > compilation of tools/testing/nvdimm fails with:
> > > >
> > > >   Building modules, stage 2.
> > > >   MODPOST 11 modules
> > > > ERROR: "dax_pmem_compat_test" [tools/testing/nvdimm/test/nfit_test.ko] undefined!
> > > >
> > > > Fix the problem by calling dax_pmem_compat_test() only if the kernel has
> > > > the required functionality.
> > > >
> > > > Signed-off-by: Jan Kara <jack@suse.cz>
> > >
> > > What's the motivation?  Is this just to fix randconfig builds?  The
> > > reason I ask is that the test suite will expect to be able to find the
> > > dax_pmem_compat module, so it doesn't make sense to me to disable those
> > > tests only in the kernel as you'll hit a problem when running the tests
> > > anyway.
> >
> > Yeah, at a minimum you'd also need to go fix up nfit_test_init() to
> > not check for the dax_pmem_compat module:
> >
> > https://github.com/pmem/ndctl/blob/master/test/core.c#L119
>
> OK.
>
> > > But, I understand if you want to prevent build bots from hitting
> > > compilation failures due to this.
> >
> > Hmm, build bots would only hit what's covered by
> > CONFIG_NVDIMM_TEST_BUILD, and that's only building
> > tools/testing/nvdimm/test/iomap.c.
> >
> > Jan, were you just looking to use nfit_test outside of running the
> > ndctl test suites? Or was this just a drive-by compilation test?
>
> The problem is following: We build our distro kernels without
> CONFIG_DEV_DAX_PMEM_COMPAT because we don't need that functionality. And
> Jing Han (from Intel ;) is now complaining that he cannot compile and run
> the ndctl testsuite on our kernels... It seems stupid to enable that config
> option for all distro users just to be able to run the testsuite but OTOH
> it would be neat to be able to run the testsuite with stock distro
> config.

Sounds good, minus the fact that Jing and I were not on the same page.
I'll send the ndctl fixup.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org