From: Guenter Roeck <linux@roeck-us.net>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-nvme@lists.infradead.org, linux-hwmon@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@fb.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Jean Delvare <jdelvare@suse.com>,
Sagi Grimberg <sagi@grimberg.me>,
Sujith Thomas <sujith.thomas@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Keith Busch <kbusch@kernel.org>,
Darren Hart <dvhart@infradead.org>,
Zhang Rui <rui.zhang@intel.com>, Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH 2/8] ACPI: thermal: switch to use <linux/temperature.h> helpers
Date: Sun, 24 Nov 2019 07:17:46 -0800 [thread overview]
Message-ID: <00fff683-d0e2-67ae-83e3-c472fdbe9e1d@roeck-us.net> (raw)
In-Reply-To: <1574604530-9024-3-git-send-email-akinobu.mita@gmail.com>
On 11/24/19 6:08 AM, Akinobu Mita wrote:
> This switches the ACPI thermal zone driver to use celsius_to_deci_kelvin()
> and deci_kelvin_to_celsius() in <linux/temperature.h> instead of helpers
> in <linux/thermal.h>.
>
> This is preparation for centralizing the kelvin to/from Celsius conversion
> helpers in <linux/temprature.h>.
>
s/temprature/temperature/
Looks like this applies to all patches.
> Cc: Sujith Thomas <sujith.thomas@intel.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@verdurent.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> drivers/acpi/thermal.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index d831a61..bd9b6eb 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -297,7 +297,9 @@ static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
> if (crt == -1) {
> tz->trips.critical.flags.valid = 0;
> } else if (crt > 0) {
> - unsigned long crt_k = CELSIUS_TO_DECI_KELVIN(crt);
> + unsigned long crt_k =
> + celsius_to_deci_kelvin(crt);
> +
> /*
> * Allow override critical threshold
> */
> @@ -333,7 +335,7 @@ static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
> if (psv == -1) {
> status = AE_SUPPORT;
> } else if (psv > 0) {
> - tmp = CELSIUS_TO_DECI_KELVIN(psv);
> + tmp = celsius_to_deci_kelvin(psv);
> status = AE_OK;
> } else {
> status = acpi_evaluate_integer(tz->device->handle,
> @@ -413,7 +415,7 @@ static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
> break;
> if (i == 1)
> tz->trips.active[0].temperature =
> - CELSIUS_TO_DECI_KELVIN(act);
> + celsius_to_deci_kelvin(act);
> else
> /*
> * Don't allow override higher than
> @@ -421,9 +423,9 @@ static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
> */
> tz->trips.active[i - 1].temperature =
> (tz->trips.active[i - 2].temperature <
> - CELSIUS_TO_DECI_KELVIN(act) ?
> + celsius_to_deci_kelvin(act) ?
> tz->trips.active[i - 2].temperature :
> - CELSIUS_TO_DECI_KELVIN(act));
> + celsius_to_deci_kelvin(act));
> break;
> } else {
> tz->trips.active[i].temperature = tmp;
> @@ -1087,7 +1089,8 @@ static int acpi_thermal_add(struct acpi_device *device)
> INIT_WORK(&tz->thermal_check_work, acpi_thermal_check_fn);
>
> pr_info(PREFIX "%s [%s] (%ld C)\n", acpi_device_name(device),
> - acpi_device_bid(device), DECI_KELVIN_TO_CELSIUS(tz->temperature));
> + acpi_device_bid(device),
> + deci_kelvin_to_celsius(tz->temperature));
> goto end;
>
> free_memory:
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-24 15:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 14:08 [PATCH 0/8] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita
2019-11-24 14:08 ` [PATCH 1/8] " Akinobu Mita
2019-11-24 14:57 ` Andy Shevchenko
2019-11-25 14:29 ` Akinobu Mita
2019-11-25 19:05 ` Andy Shevchenko
2019-11-24 14:08 ` [PATCH 2/8] ACPI: thermal: switch to use <linux/temperature.h> helpers Akinobu Mita
2019-11-24 15:17 ` Guenter Roeck [this message]
2019-11-25 14:31 ` Akinobu Mita
2019-11-24 14:08 ` [PATCH 3/8] platform/x86: asus-wmi: " Akinobu Mita
2019-11-24 19:54 ` Andy Shevchenko
2019-11-25 14:31 ` Akinobu Mita
2019-11-25 19:06 ` Andy Shevchenko
2019-11-24 14:08 ` [PATCH 4/8] platform/x86: intel_menlow: " Akinobu Mita
2019-11-24 19:57 ` Andy Shevchenko
2019-11-25 14:34 ` Akinobu Mita
2019-11-25 19:07 ` Andy Shevchenko
2019-11-26 14:34 ` Akinobu Mita
2019-11-24 14:08 ` [PATCH 5/8] thermal: int340x: " Akinobu Mita
2019-11-24 14:08 ` [PATCH 6/8] thermal: intel_pch: " Akinobu Mita
2019-11-24 15:15 ` Guenter Roeck
2019-11-24 14:08 ` [PATCH 7/8] nvme: hwmon: " Akinobu Mita
2019-11-25 6:59 ` Christoph Hellwig
2019-11-24 14:08 ` [PATCH 8/8] thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h> Akinobu Mita
2019-11-24 20:00 ` Andy Shevchenko
2019-11-25 14:39 ` Akinobu Mita
2019-11-25 19:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fff683-d0e2-67ae-83e3-c472fdbe9e1d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akinobu.mita@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=andy@infradead.org \
--cc=axboe@fb.com \
--cc=daniel.lezcano@linaro.org \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=hch@lst.de \
--cc=jdelvare@suse.com \
--cc=kbusch@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sagi@grimberg.me \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).