From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH v4 3/4] nvme: add uevent variables for controller devices
Date: Fri, 6 Sep 2019 14:59:53 +0200 [thread overview]
Message-ID: <20190906125953.GA8873@lst.de> (raw)
In-Reply-To: <20190904215954.15423-4-sagi@grimberg.me>
On Wed, Sep 04, 2019 at 02:59:52PM -0700, Sagi Grimberg wrote:
> When we send uevents to userspace, add controller specific
> environment variables to uniquly identify the controller beyond
> its device name.
>
> This will be useful to address discovery log change events by
> actually verifying that the discovery controller is indeed the
> same as the device that generated the event.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index fccf28d77c03..7a1df95ec840 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3630,6 +3630,33 @@ void nvme_remove_namespaces(struct nvme_ctrl *ctrl)
> }
> EXPORT_SYMBOL_GPL(nvme_remove_namespaces);
>
> +static int nvme_class_uevent(struct device *d, struct kobj_uevent_env *env)
> +{
> + struct nvme_ctrl *ctrl =
> + container_of(d, struct nvme_ctrl, ctrl_device);
Why the weird variable name of d instead of dev? as we usually use?
> + if (opts) {
if (!opts)
return;
? But then again how we can end up here without ctrl->opts?
> + ret = add_uevent_var(env, "NVME_TRSVCID=%s",
> + (opts && opts->trsvcid) ? opts->trsvcid : "none");
No need to check opts here again.
> + ret = add_uevent_var(env, "NVME_HOST_TRADDR=%s",
> + (opts && opts->host_traddr) ? opts->host_traddr : "none");
Same here.
Otherwise this looks fine modulo the nitpick from James.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-06 13:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:59 [PATCH v4 0/4] Support discovery log change events Sagi Grimberg
2019-09-04 21:59 ` [PATCH v4 1/4] nvme-fabrics: allow discovery subsystems accept a kato Sagi Grimberg
2019-09-09 16:47 ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 2/4] nvme: enable aen regardless of the presence of I/O queues Sagi Grimberg
2019-09-09 11:17 ` Hannes Reinecke
2019-09-09 16:48 ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 3/4] nvme: add uevent variables for controller devices Sagi Grimberg
2019-09-04 23:17 ` James Smart
2019-09-05 0:18 ` Sagi Grimberg
2019-09-05 16:00 ` James Smart
2019-09-05 20:06 ` Sagi Grimberg
2019-09-06 12:59 ` Christoph Hellwig [this message]
2019-09-06 18:07 ` Sagi Grimberg
2019-09-09 11:18 ` Hannes Reinecke
2019-09-04 21:59 ` [PATCH v4 4/4] nvme: send discovery log page change events to userspace Sagi Grimberg
2019-09-06 13:00 ` Christoph Hellwig
2019-09-09 16:50 ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 5/4 nvme-cli] udev: convert the discovery event handler to the kernel support Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906125953.GA8873@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).