From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 4/4] nvme: send discovery log page change events to userspace
Date: Mon, 9 Sep 2019 16:50:00 +0000 [thread overview]
Message-ID: <BYAPR04MB5749EE58BDD4B39F9B39EC1586B70@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190904215954.15423-5-sagi@grimberg.me
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 09/04/2019 03:00 PM, Sagi Grimberg wrote:
> If the controller supports discovery log page change events,
> we want to enable it. When we see a discovery log change event
> we will send it up to userspace and expect it to handle it.
>
> Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
> Reviewed-by: James Smart <james.smart@broadcom.com>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 7a1df95ec840..b1ff49ffde25 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1186,7 +1186,8 @@ int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count)
> EXPORT_SYMBOL_GPL(nvme_set_queue_count);
>
> #define NVME_AEN_SUPPORTED \
> - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | NVME_AEN_CFG_ANA_CHANGE)
> + (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | NVME_AEN_CFG_ANA_CHANGE | \
> + NVME_AEN_CFG_DISC_CHANGE)
>
> static void nvme_enable_aen(struct nvme_ctrl *ctrl)
> {
> @@ -3763,6 +3764,9 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
> queue_work(nvme_wq, &ctrl->ana_work);
> break;
> #endif
> + case NVME_AER_NOTICE_DISC_CHANGED:
> + ctrl->aen_result = result;
> + break;
> default:
> dev_warn(ctrl->device, "async event result %08x\n", result);
> }
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-09 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:59 [PATCH v4 0/4] Support discovery log change events Sagi Grimberg
2019-09-04 21:59 ` [PATCH v4 1/4] nvme-fabrics: allow discovery subsystems accept a kato Sagi Grimberg
2019-09-09 16:47 ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 2/4] nvme: enable aen regardless of the presence of I/O queues Sagi Grimberg
2019-09-09 11:17 ` Hannes Reinecke
2019-09-09 16:48 ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 3/4] nvme: add uevent variables for controller devices Sagi Grimberg
2019-09-04 23:17 ` James Smart
2019-09-05 0:18 ` Sagi Grimberg
2019-09-05 16:00 ` James Smart
2019-09-05 20:06 ` Sagi Grimberg
2019-09-06 12:59 ` Christoph Hellwig
2019-09-06 18:07 ` Sagi Grimberg
2019-09-09 11:18 ` Hannes Reinecke
2019-09-04 21:59 ` [PATCH v4 4/4] nvme: send discovery log page change events to userspace Sagi Grimberg
2019-09-06 13:00 ` Christoph Hellwig
2019-09-09 16:50 ` Chaitanya Kulkarni [this message]
2019-09-04 21:59 ` [PATCH v4 5/4 nvme-cli] udev: convert the discovery event handler to the kernel support Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5749EE58BDD4B39F9B39EC1586B70@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).