From: Keith Busch <kbusch@kernel.org>
To: Balbir Singh <sblbir@amzn.com>
Cc: axboe@fb.com, hch@lst.de, linux-nvme@lists.infradead.org,
sagi@grimberg.me
Subject: Re: [PATCH 2/2] nvme/host/core: Allow overriding of wait_ready timeout
Date: Fri, 13 Sep 2019 08:55:14 -0600 [thread overview]
Message-ID: <20190913145513.GA17139@keith-busch> (raw)
In-Reply-To: <20190913024432.7705-2-sblbir@amzn.com>
On Fri, Sep 13, 2019 at 02:44:32AM +0000, Balbir Singh wrote:
> Largely for debugging purposes where controllers with large
> timeouts get stuck during reset.
>
> Signed-off-by: Balbir Singh <sblbir@amzn.com>
> ---
> drivers/nvme/host/core.c | 8 ++++++++
> drivers/nvme/host/nvme.h | 3 +++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 45b96c6ac2d5..fa7982dfe551 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -40,6 +40,11 @@ module_param_named(io_timeout, nvme_io_timeout, uint, 0644);
> MODULE_PARM_DESC(io_timeout, "timeout in seconds for I/O");
> EXPORT_SYMBOL_GPL(nvme_io_timeout);
>
> +unsigned int nvme_wait_ready_timeout = 0;
> +module_param_named(wait_ready_timeout, nvme_wait_ready_timeout, uint, 0644);
> +MODULE_PARM_DESC(wait_ready_timeout, "timeout in seconds for wait ready on reset");
> +EXPORT_SYMBOL_GPL(nvme_wait_ready_timeout);
There's no need to export this symbol.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-13 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 2:44 [PATCH 1/2] nvme/host/pci: Fix a race in controller removal Balbir Singh
2019-09-13 2:44 ` [PATCH 2/2] nvme/host/core: Allow overriding of wait_ready timeout Balbir Singh
2019-09-13 14:55 ` Keith Busch [this message]
2019-09-13 20:47 ` Singh, Balbir
2019-09-13 15:01 ` [PATCH 1/2] nvme/host/pci: Fix a race in controller removal Keith Busch
2019-09-13 20:58 ` Singh, Balbir
2019-09-13 21:40 ` Bart Van Assche
2019-09-13 22:01 ` Singh, Balbir
2019-09-13 22:46 ` Singh, Balbir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913145513.GA17139@keith-busch \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sblbir@amzn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).