linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Singh, Balbir" <sblbir@amazon.com>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"sblbir@amzn.com" <sblbir@amzn.com>
Cc: "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 1/2] nvme/host/pci: Fix a race in controller removal
Date: Fri, 13 Sep 2019 14:40:21 -0700	[thread overview]
Message-ID: <ad85a4ac-7b88-a855-abe2-6fab85c703a8@acm.org> (raw)
In-Reply-To: <3cf02675ea58f3e3b91f23f63e53f1d2010fadf9.camel@amazon.com>

On 9/13/19 1:58 PM, Singh, Balbir wrote:
> The real issue is that by then udevd has already called into blk_queue_enter()
> and is waiting on wait_event(q->mq_freeze_wq,...), so we do need to unfreeze
> and wake_all waiting on the event.

I don't think that's correct. blk_set_queue_dying() wakes up 
blk_queue_enter() and causes it to return -ENODEV.

Bart.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-09-13 21:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  2:44 [PATCH 1/2] nvme/host/pci: Fix a race in controller removal Balbir Singh
2019-09-13  2:44 ` [PATCH 2/2] nvme/host/core: Allow overriding of wait_ready timeout Balbir Singh
2019-09-13 14:55   ` Keith Busch
2019-09-13 20:47     ` Singh, Balbir
2019-09-13 15:01 ` [PATCH 1/2] nvme/host/pci: Fix a race in controller removal Keith Busch
2019-09-13 20:58   ` Singh, Balbir
2019-09-13 21:40     ` Bart Van Assche [this message]
2019-09-13 22:01       ` Singh, Balbir
2019-09-13 22:46         ` Singh, Balbir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad85a4ac-7b88-a855-abe2-6fab85c703a8@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=sblbir@amazon.com \
    --cc=sblbir@amzn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).