From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org,
Akinobu Mita <akinobu.mita@gmail.com>, Jens Axboe <axboe@fb.com>,
Chris Healy <Chris.Healy@zii.aero>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvme: Add hardware monitoring support
Date: Mon, 28 Oct 2019 17:08:58 +0900 [thread overview]
Message-ID: <20191028080858.GB1718@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20191028073953.GA20443@lst.de>
On Mon, Oct 28, 2019 at 08:39:53AM +0100, Christoph Hellwig wrote:
> On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote:
> > nvme devices report temperature information in the controller information
> > (for limits) and in the smart log. Currently, the only means to retrieve
> > this information is the nvme command line interface, which requires
> > super-user privileges.
> >
> > At the same time, it would be desirable to use NVME temperature information
> > for thermal control.
> >
> > This patch adds support to read NVME temperatures from the kernel using the
> > hwmon API and adds temperature zones for NVME drives. The thermal subsystem
> > can use this information to set thermal policies, and userspace can access
> > it using libsensors and/or the "sensors" command.
>
> So these reported values seem to generate some interest. Adding Akinobu
> Mita who also planned to wire them up to the thermal framework. I don't
> really know either upper layer so I'm not sure which is the right one,
> but with this just like with the previous series I am quite worried that
> we add a lot of kernel boilerplate code for information people can
> trivially get using nvme-cli.
I think it's nvme-cli requires root, where this conveniently doesn't
need those elevated rights.
I'm not familiar with either upper level framework either; my only review
comment for this patch is to use devm_kfree() for the error cases.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-28 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 2:41 [PATCH] nvme: Add hardware monitoring support Guenter Roeck
2019-10-28 7:39 ` Christoph Hellwig
2019-10-28 8:08 ` Keith Busch [this message]
2019-10-28 13:27 ` Guenter Roeck
2019-10-28 18:01 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028080858.GB1718@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=Chris.Healy@zii.aero \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).