Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* Regression: kernel 5.4 does not show NVME SSD
@ 2019-12-02  9:31 Ingo Brunberg
  2019-12-02 15:39 ` Keith Busch
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Brunberg @ 2019-12-02  9:31 UTC (permalink / raw)
  To: linux-nvme

Hi experts,

starting with linux kernel 5.4 my NVME SSD from HP is no longer detected
correctly, nvme list shows no result. I made no relevant changes
regarding .config between kernels 5.3 and 5.4.

Please have a look at this bugzilla entry:
https://bugzilla.kernel.org/show_bug.cgi?id=205679

Maybe all SSDs with a Silicon Motion 2263 controller are affected.
If you need more information, please ask.

Regards
Ingo Brunberg

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Regression: kernel 5.4 does not show NVME SSD
  2019-12-02  9:31 Regression: kernel 5.4 does not show NVME SSD Ingo Brunberg
@ 2019-12-02 15:39 ` Keith Busch
  2019-12-06 22:44   ` Sagi Grimberg
  0 siblings, 1 reply; 4+ messages in thread
From: Keith Busch @ 2019-12-02 15:39 UTC (permalink / raw)
  To: Ingo Brunberg; +Cc: linux-nvme

On Mon, Dec 02, 2019 at 10:31:18AM +0100, Ingo Brunberg wrote:
> Hi experts,
> 
> starting with linux kernel 5.4 my NVME SSD from HP is no longer detected
> correctly, nvme list shows no result. I made no relevant changes
> regarding .config between kernels 5.3 and 5.4.
> 
> Please have a look at this bugzilla entry:
> https://bugzilla.kernel.org/show_bug.cgi?id=205679
> 
> Maybe all SSDs with a Silicon Motion 2263 controller are affected.
> If you need more information, please ask.

It's a regression from commit 538af88ea7d9de241e6b6f006e9049c4d96723bb.
This one should have only returned the error if < 0, otherwise we can
proceed. Will get post a patch shortly with a 5.4 stable request.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Regression: kernel 5.4 does not show NVME SSD
  2019-12-02 15:39 ` Keith Busch
@ 2019-12-06 22:44   ` Sagi Grimberg
  2019-12-06 22:58     ` Keith Busch
  0 siblings, 1 reply; 4+ messages in thread
From: Sagi Grimberg @ 2019-12-06 22:44 UTC (permalink / raw)
  To: Keith Busch, Ingo Brunberg; +Cc: linux-nvme


>> Hi experts,
>>
>> starting with linux kernel 5.4 my NVME SSD from HP is no longer detected
>> correctly, nvme list shows no result. I made no relevant changes
>> regarding .config between kernels 5.3 and 5.4.
>>
>> Please have a look at this bugzilla entry:
>> https://bugzilla.kernel.org/show_bug.cgi?id=205679
>>
>> Maybe all SSDs with a Silicon Motion 2263 controller are affected.
>> If you need more information, please ask.
> 
> It's a regression from commit 538af88ea7d9de241e6b6f006e9049c4d96723bb.
> This one should have only returned the error if < 0, otherwise we can
> proceed. Will get post a patch shortly with a 5.4 stable request.

Should we have something that is more granular rather than any positive
error?

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Regression: kernel 5.4 does not show NVME SSD
  2019-12-06 22:44   ` Sagi Grimberg
@ 2019-12-06 22:58     ` Keith Busch
  0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2019-12-06 22:58 UTC (permalink / raw)
  To: Sagi Grimberg; +Cc: Ingo Brunberg, linux-nvme

On Fri, Dec 06, 2019 at 02:44:23PM -0800, Sagi Grimberg wrote:
> > This one should have only returned the error if < 0, otherwise we can
> > proceed. Will get post a patch shortly with a 5.4 stable request.
> 
> Should we have something that is more granular rather than any positive
> error?

I don't think so, otherwise we'll be chasing new errors from disfunctional
controllers. As long as we get a response of any kind, we can use the
controller. It's only when we don't get a response, which is what the
negative return codes are for.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02  9:31 Regression: kernel 5.4 does not show NVME SSD Ingo Brunberg
2019-12-02 15:39 ` Keith Busch
2019-12-06 22:44   ` Sagi Grimberg
2019-12-06 22:58     ` Keith Busch

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git