* [PATCH v2] nvme: log additional message for controller status
@ 2020-02-27 16:45 Rupesh Girase
2020-03-01 0:40 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rupesh Girase @ 2020-02-27 16:45 UTC (permalink / raw)
To: kbusch; +Cc: axboe, Rupesh Girase, hch, linux-nvme
Log the controller status to know more about issue if it
lies within kernel nvme subsytem or controller is unhealthy.
Signed-off-by: Rupesh Girase <rgirase@redhat.com>
---
drivers/nvme/host/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a4d8c90..9819646 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2079,8 +2079,8 @@ static int nvme_wait_ready(struct nvme_ctrl *ctrl, u64 cap, bool enabled)
return -EINTR;
if (time_after(jiffies, timeout)) {
dev_err(ctrl->device,
- "Device not ready; aborting %s\n", enabled ?
- "initialisation" : "reset");
+ "Device not ready; aborting %s, CSTS=0x%x\n",
+ enabled ? "initialisation" : "reset", csts);
return -ENODEV;
}
}
--
1.8.3.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvme: log additional message for controller status
2020-02-27 16:45 [PATCH v2] nvme: log additional message for controller status Rupesh Girase
@ 2020-03-01 0:40 ` Chaitanya Kulkarni
2020-03-02 17:47 ` Sagi Grimberg
2020-03-02 22:21 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-03-01 0:40 UTC (permalink / raw)
To: Rupesh Girase, kbusch; +Cc: axboe, hch, linux-nvme
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulakrni@wdc.com>
On 02/27/2020 08:45 AM, Rupesh Girase wrote:
> Log the controller status to know more about issue if it
> lies within kernel nvme subsytem or controller is unhealthy.
>
> Signed-off-by: Rupesh Girase<rgirase@redhat.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvme: log additional message for controller status
2020-02-27 16:45 [PATCH v2] nvme: log additional message for controller status Rupesh Girase
2020-03-01 0:40 ` Chaitanya Kulkarni
@ 2020-03-02 17:47 ` Sagi Grimberg
2020-03-02 22:21 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-03-02 17:47 UTC (permalink / raw)
To: Rupesh Girase, kbusch; +Cc: axboe, hch, linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvme: log additional message for controller status
2020-02-27 16:45 [PATCH v2] nvme: log additional message for controller status Rupesh Girase
2020-03-01 0:40 ` Chaitanya Kulkarni
2020-03-02 17:47 ` Sagi Grimberg
@ 2020-03-02 22:21 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2020-03-02 22:21 UTC (permalink / raw)
To: Rupesh Girase; +Cc: axboe, hch, linux-nvme
On Thu, Feb 27, 2020 at 10:15:26PM +0530, Rupesh Girase wrote:
> Log the controller status to know more about issue if it
> lies within kernel nvme subsytem or controller is unhealthy.
>
> Signed-off-by: Rupesh Girase <rgirase@redhat.com>
Applied with the reviews for 5.7, thank you.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-02 22:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 16:45 [PATCH v2] nvme: log additional message for controller status Rupesh Girase
2020-03-01 0:40 ` Chaitanya Kulkarni
2020-03-02 17:47 ` Sagi Grimberg
2020-03-02 22:21 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).