From: Tony Asleson <tasleson@redhat.com>
To: linux-nvme@lists.infradead.org
Subject: [PATCH 4/6] nvme.py: Sync the containing directory
Date: Fri, 20 Mar 2020 15:39:44 -0500 [thread overview]
Message-ID: <20200320203946.37338-5-tasleson@redhat.com> (raw)
In-Reply-To: <20200320203946.37338-1-tasleson@redhat.com>
It's apparent that some thought went into making sure the config
file makes it atomically to the fs. However, one thing is missing
which is doing a fsync on the containing directory of the config file.
See: https://lwn.net/Articles/457667/
Signed-off-by: Tony Asleson <tasleson@redhat.com>
---
nvmet/nvme.py | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 55c3930..4817124 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -305,6 +305,15 @@ class Root(CFSNode):
os.rename(savefile + ".temp", savefile)
+ # Sync the containing directory too
+ dir_fd = None
+ try:
+ dir_fd = os.open(savefile_dir, os.O_RDONLY)
+ os.fsync(dir_fd)
+ finally:
+ if dir_fd:
+ os.close(dir_fd)
+
def clear_existing(self):
'''
Remove entire current configuration.
--
2.25.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-20 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 20:39 [PATCH 0/6] nvmetcli: Misc. corrections Tony Asleson
2020-03-20 20:39 ` [PATCH 1/6] README: Update URL for configshell-fb Tony Asleson
2020-03-21 0:47 ` Chaitanya Kulkarni
2020-03-21 2:49 ` Tony Asleson
2020-03-20 20:39 ` [PATCH 2/6] nvmetcli: Improve IOError handling on restore Tony Asleson
2020-03-20 20:39 ` [PATCH 3/6] nvme.py: Explicit close is redundant Tony Asleson
2020-03-21 1:06 ` Chaitanya Kulkarni
2020-03-20 20:39 ` Tony Asleson [this message]
2020-03-20 20:39 ` [PATCH 5/6] nvme.py: Make modprobe work for kmod lib too Tony Asleson
2020-03-20 20:39 ` [PATCH 6/6] test_nvmet.py: Use string.ascii_lowercase Tony Asleson
2020-03-21 1:12 ` Chaitanya Kulkarni
2020-03-21 2:34 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320203946.37338-5-tasleson@redhat.com \
--to=tasleson@redhat.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).