From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Tony Asleson <tasleson@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 3/6] nvme.py: Explicit close is redundant
Date: Sat, 21 Mar 2020 01:06:49 +0000 [thread overview]
Message-ID: <BYAPR04MB4965971C531DBD1662B4875A86F20@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200320203946.37338-4-tasleson@redhat.com
On 03/20/2020 01:43 PM, Tony Asleson wrote:
> One of the benefits of using 'with' statement for open files is the
> close is going to be called regardless of what happens.
>
> Signed-off-by: Tony Asleson<tasleson@redhat.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-21 1:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 20:39 [PATCH 0/6] nvmetcli: Misc. corrections Tony Asleson
2020-03-20 20:39 ` [PATCH 1/6] README: Update URL for configshell-fb Tony Asleson
2020-03-21 0:47 ` Chaitanya Kulkarni
2020-03-21 2:49 ` Tony Asleson
2020-03-20 20:39 ` [PATCH 2/6] nvmetcli: Improve IOError handling on restore Tony Asleson
2020-03-20 20:39 ` [PATCH 3/6] nvme.py: Explicit close is redundant Tony Asleson
2020-03-21 1:06 ` Chaitanya Kulkarni [this message]
2020-03-20 20:39 ` [PATCH 4/6] nvme.py: Sync the containing directory Tony Asleson
2020-03-20 20:39 ` [PATCH 5/6] nvme.py: Make modprobe work for kmod lib too Tony Asleson
2020-03-20 20:39 ` [PATCH 6/6] test_nvmet.py: Use string.ascii_lowercase Tony Asleson
2020-03-21 1:12 ` Chaitanya Kulkarni
2020-03-21 2:34 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965971C531DBD1662B4875A86F20@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=tasleson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).