* [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE)
@ 2020-04-13 14:15 Leon Romanovsky
2020-04-13 14:15 ` [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason Leon Romanovsky
2020-04-20 13:36 ` [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
0 siblings, 2 replies; 7+ messages in thread
From: Leon Romanovsky @ 2020-04-13 14:15 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Leon Romanovsky, target-devel, Jakub Kicinski, David S. Miller,
Sagi Grimberg
From: Leon Romanovsky <leonro@mellanox.com>
Changelog:
v2:
* Rebased on latest rdma-next and removed already accepted patches.
* Updated all rdma_reject in-kernel users to provide reject reason.
v1: Dropped field_avail patch in favor of mass conversion to use function
which already exists in the kernel code.
https://lore.kernel.org/lkml/20200310091438.248429-1-leon@kernel.org
v0: https://lore.kernel.org/lkml/20200305150105.207959-1-leon@kernel.org
Enhanced Connection Established or ECE is new negotiation scheme
introduced in IBTA v1.4 to exchange extra information about nodes
capabilities and later negotiate them at the connection establishment
phase.
The RDMA-CM messages (REQ, REP, SIDR_REQ and SIDR_REP) were extended
to carry two fields, one new and another gained new functionality:
* VendorID is a new field that indicates that common subset of vendor
option bits are supported as indicated by that VendorID.
* AttributeModifier already exists, but overloaded to indicate which
vendor options are supported by this VendorID.
This is kernel part of such functionality which is responsible to get data
from librdmacm and properly create and handle RDMA-CM messages.
Thanks
Leon Romanovsky (7):
RDMA/cm: Add Enhanced Connection Establishment (ECE) bits
RDMA/uapi: Add ECE definitions to UCMA
RDMA/ucma: Extend ucma_connect to receive ECE parameters
RDMA/ucma: Deliver ECE parameters through UCMA events
RDMA/cm: Send and receive ECE parameter over the wire
RDMA/cma: Connect ECE to rdma_accept
RDMA/cma: Provide ECE reject reason
drivers/infiniband/core/cm.c | 41 ++++++++++++++++---
drivers/infiniband/core/cma.c | 52 ++++++++++++++++++++++---
drivers/infiniband/core/cma_priv.h | 1 +
drivers/infiniband/core/ucma.c | 40 +++++++++++++++----
drivers/infiniband/ulp/isert/ib_isert.c | 4 +-
drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
drivers/nvme/target/rdma.c | 2 +-
include/rdma/ib_cm.h | 10 ++++-
include/rdma/ibta_vol1_c12.h | 6 +++
include/rdma/rdma_cm.h | 18 ++++++++-
include/uapi/rdma/rdma_user_cm.h | 15 ++++++-
net/rds/ib_cm.c | 2 +-
12 files changed, 167 insertions(+), 26 deletions(-)
--
2.25.2
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason
2020-04-13 14:15 [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
@ 2020-04-13 14:15 ` Leon Romanovsky
2020-05-25 18:14 ` Jason Gunthorpe
2020-04-20 13:36 ` [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
1 sibling, 1 reply; 7+ messages in thread
From: Leon Romanovsky @ 2020-04-13 14:15 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Leon Romanovsky, target-devel, Jakub Kicinski, David S. Miller,
Sagi Grimberg
From: Leon Romanovsky <leonro@mellanox.com>
IBTA declares "vendor option not supported" reject reason in REJ
messages if passive side doesn't want to accept proposed ECE options.
Due to the fact that ECE is managed by userspace, there is a need to let
users to provide such rejected reason.
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
drivers/infiniband/core/cma.c | 12 +++++++-----
drivers/infiniband/core/ucma.c | 7 ++++++-
drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
drivers/nvme/target/rdma.c | 2 +-
include/rdma/ib_cm.h | 3 ++-
include/rdma/rdma_cm.h | 3 ++-
include/uapi/rdma/rdma_user_cm.h | 7 ++++++-
net/rds/ib_cm.c | 2 +-
9 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 409f752f40ae..b79f71b10593 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4183,7 +4183,7 @@ int __rdma_accept(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
return 0;
reject:
cma_modify_qp_err(id_priv);
- rdma_reject(id, NULL, 0);
+ rdma_reject(id, NULL, 0, 0);
return ret;
}
EXPORT_SYMBOL(__rdma_accept);
@@ -4223,7 +4223,7 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
EXPORT_SYMBOL(rdma_notify);
int rdma_reject(struct rdma_cm_id *id, const void *private_data,
- u8 private_data_len)
+ u8 private_data_len, enum rdma_ucm_reject_reason reason)
{
struct rdma_id_private *id_priv;
int ret;
@@ -4237,10 +4237,12 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data,
ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,
private_data, private_data_len);
} else {
+ enum ib_cm_rej_reason r =
+ (reason) ?: IB_CM_REJ_CONSUMER_DEFINED;
+
trace_cm_send_rej(id_priv);
- ret = ib_send_cm_rej(id_priv->cm_id.ib,
- IB_CM_REJ_CONSUMER_DEFINED, NULL,
- 0, private_data, private_data_len);
+ ret = ib_send_cm_rej(id_priv->cm_id.ib, r, NULL, 0,
+ private_data, private_data_len);
}
} else if (rdma_cap_iw_cm(id->device, id->port_num)) {
ret = iw_cm_reject(id_priv->cm_id.iw,
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index d41598954cc4..99482dc5934b 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1178,12 +1178,17 @@ static ssize_t ucma_reject(struct ucma_file *file, const char __user *inbuf,
if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
return -EFAULT;
+ if (cmd.reason &&
+ cmd.reason != RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
+ return -EINVAL;
+
ctx = ucma_get_ctx_dev(file, cmd.id);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
mutex_lock(&ctx->mutex);
- ret = rdma_reject(ctx->cm_id, cmd.private_data, cmd.private_data_len);
+ ret = rdma_reject(ctx->cm_id, cmd.private_data, cmd.private_data_len,
+ cmd.reason);
mutex_unlock(&ctx->mutex);
ucma_put_ctx(ctx);
return ret;
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a1a035270cab..42f78d0b61cc 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -502,7 +502,7 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event)
if (!np->enabled) {
spin_unlock_bh(&np->np_thread_lock);
isert_dbg("iscsi_np is not enabled, reject connect request\n");
- return rdma_reject(cma_id, NULL, 0);
+ return rdma_reject(cma_id, NULL, 0, 0);
}
spin_unlock_bh(&np->np_thread_lock);
@@ -553,7 +553,7 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event)
isert_free_login_buf(isert_conn);
out:
kfree(isert_conn);
- rdma_reject(cma_id, NULL, 0);
+ rdma_reject(cma_id, NULL, 0, 0);
return ret;
}
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 7047f6a5d0a3..44eefa83bfc6 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -2496,7 +2496,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
SRP_BUF_FORMAT_INDIRECT);
if (rdma_cm_id)
- rdma_reject(rdma_cm_id, rej, sizeof(*rej));
+ rdma_reject(rdma_cm_id, rej, sizeof(*rej), 0);
else
ib_send_cm_rej(ib_cm_id, IB_CM_REJ_CONSUMER_DEFINED, NULL, 0,
rej, sizeof(*rej));
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index fd47de0e4e4e..9f3fea89b254 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1138,7 +1138,7 @@ static int nvmet_rdma_cm_reject(struct rdma_cm_id *cm_id,
rej.recfmt = cpu_to_le16(NVME_RDMA_CM_FMT_1_0);
rej.sts = cpu_to_le16(status);
- return rdma_reject(cm_id, (void *)&rej, sizeof(rej));
+ return rdma_reject(cm_id, (void *)&rej, sizeof(rej), 0);
}
static struct nvmet_rdma_queue *
diff --git a/include/rdma/ib_cm.h b/include/rdma/ib_cm.h
index 0f1ea5f2d01c..ed328a99ed0a 100644
--- a/include/rdma/ib_cm.h
+++ b/include/rdma/ib_cm.h
@@ -168,7 +168,8 @@ enum ib_cm_rej_reason {
IB_CM_REJ_INVALID_CLASS_VERSION = 31,
IB_CM_REJ_INVALID_FLOW_LABEL = 32,
IB_CM_REJ_INVALID_ALT_FLOW_LABEL = 33,
- IB_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35,
+ IB_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED =
+ RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED,
};
struct ib_cm_rej_event_param {
diff --git a/include/rdma/rdma_cm.h b/include/rdma/rdma_cm.h
index 8d961d8b7cdb..f8781b132f62 100644
--- a/include/rdma/rdma_cm.h
+++ b/include/rdma/rdma_cm.h
@@ -324,11 +324,12 @@ int __rdma_accept_ece(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
*/
int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event);
+
/**
* rdma_reject - Called to reject a connection request or response.
*/
int rdma_reject(struct rdma_cm_id *id, const void *private_data,
- u8 private_data_len);
+ u8 private_data_len, enum rdma_ucm_reject_reason reason);
/**
* rdma_disconnect - This function disconnects the associated QP and
diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
index c4ca1412bcf9..e545f2de1e13 100644
--- a/include/uapi/rdma/rdma_user_cm.h
+++ b/include/uapi/rdma/rdma_user_cm.h
@@ -78,6 +78,10 @@ enum rdma_ucm_port_space {
RDMA_PS_UDP = 0x0111,
};
+enum rdma_ucm_reject_reason {
+ RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35
+};
+
/*
* command ABI structures.
*/
@@ -234,7 +238,8 @@ struct rdma_ucm_accept {
struct rdma_ucm_reject {
__u32 id;
__u8 private_data_len;
- __u8 reserved[3];
+ __u8 reason; /* enum rdma_ucm_reject_reason */
+ __u8 reserved[2];
__u8 private_data[RDMA_MAX_PRIVATE_DATA];
};
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index c71f4328d138..bac8c68df66c 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -927,7 +927,7 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
if (conn)
mutex_unlock(&conn->c_cm_lock);
if (err)
- rdma_reject(cm_id, &err, sizeof(int));
+ rdma_reject(cm_id, &err, sizeof(int), 0);
return destroy;
}
--
2.25.2
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE)
2020-04-13 14:15 [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
2020-04-13 14:15 ` [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason Leon Romanovsky
@ 2020-04-20 13:36 ` Leon Romanovsky
1 sibling, 0 replies; 7+ messages in thread
From: Leon Romanovsky @ 2020-04-20 13:36 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
target-devel, Jakub Kicinski, David S. Miller, Sagi Grimberg
On Mon, Apr 13, 2020 at 05:15:31PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> Changelog:
> v2:
> * Rebased on latest rdma-next and removed already accepted patches.
> * Updated all rdma_reject in-kernel users to provide reject reason.
> v1: Dropped field_avail patch in favor of mass conversion to use function
> which already exists in the kernel code.
> https://lore.kernel.org/lkml/20200310091438.248429-1-leon@kernel.org
> v0: https://lore.kernel.org/lkml/20200305150105.207959-1-leon@kernel.org
>
> Enhanced Connection Established or ECE is new negotiation scheme
> introduced in IBTA v1.4 to exchange extra information about nodes
> capabilities and later negotiate them at the connection establishment
> phase.
>
> The RDMA-CM messages (REQ, REP, SIDR_REQ and SIDR_REP) were extended
> to carry two fields, one new and another gained new functionality:
> * VendorID is a new field that indicates that common subset of vendor
> option bits are supported as indicated by that VendorID.
> * AttributeModifier already exists, but overloaded to indicate which
> vendor options are supported by this VendorID.
>
> This is kernel part of such functionality which is responsible to get data
> from librdmacm and properly create and handle RDMA-CM messages.
>
> Thanks
>
> Leon Romanovsky (7):
> RDMA/cm: Add Enhanced Connection Establishment (ECE) bits
> RDMA/uapi: Add ECE definitions to UCMA
> RDMA/ucma: Extend ucma_connect to receive ECE parameters
> RDMA/ucma: Deliver ECE parameters through UCMA events
> RDMA/cm: Send and receive ECE parameter over the wire
> RDMA/cma: Connect ECE to rdma_accept
> RDMA/cma: Provide ECE reject reason
PR: https://github.com/linux-rdma/rdma-core/pull/745
Thanks
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason
2020-04-13 14:15 ` [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason Leon Romanovsky
@ 2020-05-25 18:14 ` Jason Gunthorpe
2020-05-25 18:22 ` Leon Romanovsky
0 siblings, 1 reply; 7+ messages in thread
From: Jason Gunthorpe @ 2020-05-25 18:14 UTC (permalink / raw)
To: Leon Romanovsky
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Leon Romanovsky, Doug Ledford, target-devel, Jakub Kicinski,
David S. Miller, Sagi Grimberg
On Mon, Apr 13, 2020 at 05:15:38PM +0300, Leon Romanovsky wrote:
> @@ -4223,7 +4223,7 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
> EXPORT_SYMBOL(rdma_notify);
>
> int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> - u8 private_data_len)
> + u8 private_data_len, enum rdma_ucm_reject_reason reason)
> {
> struct rdma_id_private *id_priv;
> int ret;
> @@ -4237,10 +4237,12 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,
> private_data, private_data_len);
> } else {
> + enum ib_cm_rej_reason r =
> + (reason) ?: IB_CM_REJ_CONSUMER_DEFINED;
> +
> trace_cm_send_rej(id_priv);
> - ret = ib_send_cm_rej(id_priv->cm_id.ib,
> - IB_CM_REJ_CONSUMER_DEFINED, NULL,
> - 0, private_data, private_data_len);
> + ret = ib_send_cm_rej(id_priv->cm_id.ib, r, NULL, 0,
> + private_data, private_data_len);
> }
> } else if (rdma_cap_iw_cm(id->device, id->port_num)) {
> ret = iw_cm_reject(id_priv->cm_id.iw,
> diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
> index d41598954cc4..99482dc5934b 100644
> +++ b/drivers/infiniband/core/ucma.c
> @@ -1178,12 +1178,17 @@ static ssize_t ucma_reject(struct ucma_file *file, const char __user *inbuf,
> if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
> return -EFAULT;
>
> + if (cmd.reason &&
> + cmd.reason != RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> + return -EINVAL;
It would be clearer to set cmd.reason to IB_CM_REJ_CONSUMER_DEFINED at
this point..
if (!cmd.reason)
cmd.reason = IB_CM_REJ_CONSUMER_DEFINED
if (cmd.reason != IB_CM_REJ_CONSUMER_DEFINED && cmd.reason !=
RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
return -EINVAL
Esaier to follow and no reason userspace shouldn't be able to
explicitly specifiy the reason's that it is allowed to use.
> index 8d961d8b7cdb..f8781b132f62 100644
> +++ b/include/rdma/rdma_cm.h
> @@ -324,11 +324,12 @@ int __rdma_accept_ece(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
> */
> int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event);
>
> +
> /**
Extra hunk?
> * rdma_reject - Called to reject a connection request or response.
> */
> int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> - u8 private_data_len);
> + u8 private_data_len, enum rdma_ucm_reject_reason reason);
>
> /**
> * rdma_disconnect - This function disconnects the associated QP and
> diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> index c4ca1412bcf9..e545f2de1e13 100644
> +++ b/include/uapi/rdma/rdma_user_cm.h
> @@ -78,6 +78,10 @@ enum rdma_ucm_port_space {
> RDMA_PS_UDP = 0x0111,
> };
>
> +enum rdma_ucm_reject_reason {
> + RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35
> +};
not sure we need ABI defines for IBTA constants?
Jason
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason
2020-05-25 18:14 ` Jason Gunthorpe
@ 2020-05-25 18:22 ` Leon Romanovsky
2020-05-25 18:36 ` Jason Gunthorpe
0 siblings, 1 reply; 7+ messages in thread
From: Leon Romanovsky @ 2020-05-25 18:22 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Doug Ledford, target-devel, Jakub Kicinski, David S. Miller,
Sagi Grimberg
On Mon, May 25, 2020 at 03:14:17PM -0300, Jason Gunthorpe wrote:
> On Mon, Apr 13, 2020 at 05:15:38PM +0300, Leon Romanovsky wrote:
> > @@ -4223,7 +4223,7 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
> > EXPORT_SYMBOL(rdma_notify);
> >
> > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > - u8 private_data_len)
> > + u8 private_data_len, enum rdma_ucm_reject_reason reason)
> > {
> > struct rdma_id_private *id_priv;
> > int ret;
> > @@ -4237,10 +4237,12 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,
> > private_data, private_data_len);
> > } else {
> > + enum ib_cm_rej_reason r =
> > + (reason) ?: IB_CM_REJ_CONSUMER_DEFINED;
> > +
> > trace_cm_send_rej(id_priv);
> > - ret = ib_send_cm_rej(id_priv->cm_id.ib,
> > - IB_CM_REJ_CONSUMER_DEFINED, NULL,
> > - 0, private_data, private_data_len);
> > + ret = ib_send_cm_rej(id_priv->cm_id.ib, r, NULL, 0,
> > + private_data, private_data_len);
> > }
> > } else if (rdma_cap_iw_cm(id->device, id->port_num)) {
> > ret = iw_cm_reject(id_priv->cm_id.iw,
> > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
> > index d41598954cc4..99482dc5934b 100644
> > +++ b/drivers/infiniband/core/ucma.c
> > @@ -1178,12 +1178,17 @@ static ssize_t ucma_reject(struct ucma_file *file, const char __user *inbuf,
> > if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
> > return -EFAULT;
> >
> > + if (cmd.reason &&
> > + cmd.reason != RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> > + return -EINVAL;
>
> It would be clearer to set cmd.reason to IB_CM_REJ_CONSUMER_DEFINED at
> this point..
>
> if (!cmd.reason)
> cmd.reason = IB_CM_REJ_CONSUMER_DEFINED
>
> if (cmd.reason != IB_CM_REJ_CONSUMER_DEFINED && cmd.reason !=
> RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> return -EINVAL
>
> Esaier to follow and no reason userspace shouldn't be able to
> explicitly specifiy the reason's that it is allowed to use.
>
>
> > index 8d961d8b7cdb..f8781b132f62 100644
> > +++ b/include/rdma/rdma_cm.h
> > @@ -324,11 +324,12 @@ int __rdma_accept_ece(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
> > */
> > int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event);
> >
> > +
> > /**
>
> Extra hunk?
>
> > * rdma_reject - Called to reject a connection request or response.
> > */
> > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > - u8 private_data_len);
> > + u8 private_data_len, enum rdma_ucm_reject_reason reason);
> >
> > /**
> > * rdma_disconnect - This function disconnects the associated QP and
> > diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> > index c4ca1412bcf9..e545f2de1e13 100644
> > +++ b/include/uapi/rdma/rdma_user_cm.h
> > @@ -78,6 +78,10 @@ enum rdma_ucm_port_space {
> > RDMA_PS_UDP = 0x0111,
> > };
> >
> > +enum rdma_ucm_reject_reason {
> > + RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35
> > +};
>
> not sure we need ABI defines for IBTA constants?
Do you want to give an option to write any number?
Right now, I'm enforcing only allowed by IBTA reason
and which is used in user space.
Thanks
>
> Jason
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason
2020-05-25 18:22 ` Leon Romanovsky
@ 2020-05-25 18:36 ` Jason Gunthorpe
2020-05-26 5:49 ` Leon Romanovsky
0 siblings, 1 reply; 7+ messages in thread
From: Jason Gunthorpe @ 2020-05-25 18:36 UTC (permalink / raw)
To: Leon Romanovsky
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Doug Ledford, target-devel, Jakub Kicinski, David S. Miller,
Sagi Grimberg
On Mon, May 25, 2020 at 09:22:42PM +0300, Leon Romanovsky wrote:
> On Mon, May 25, 2020 at 03:14:17PM -0300, Jason Gunthorpe wrote:
> > On Mon, Apr 13, 2020 at 05:15:38PM +0300, Leon Romanovsky wrote:
> > > @@ -4223,7 +4223,7 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
> > > EXPORT_SYMBOL(rdma_notify);
> > >
> > > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > - u8 private_data_len)
> > > + u8 private_data_len, enum rdma_ucm_reject_reason reason)
> > > {
> > > struct rdma_id_private *id_priv;
> > > int ret;
> > > @@ -4237,10 +4237,12 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,
> > > private_data, private_data_len);
> > > } else {
> > > + enum ib_cm_rej_reason r =
> > > + (reason) ?: IB_CM_REJ_CONSUMER_DEFINED;
> > > +
> > > trace_cm_send_rej(id_priv);
> > > - ret = ib_send_cm_rej(id_priv->cm_id.ib,
> > > - IB_CM_REJ_CONSUMER_DEFINED, NULL,
> > > - 0, private_data, private_data_len);
> > > + ret = ib_send_cm_rej(id_priv->cm_id.ib, r, NULL, 0,
> > > + private_data, private_data_len);
> > > }
> > > } else if (rdma_cap_iw_cm(id->device, id->port_num)) {
> > > ret = iw_cm_reject(id_priv->cm_id.iw,
> > > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
> > > index d41598954cc4..99482dc5934b 100644
> > > +++ b/drivers/infiniband/core/ucma.c
> > > @@ -1178,12 +1178,17 @@ static ssize_t ucma_reject(struct ucma_file *file, const char __user *inbuf,
> > > if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
> > > return -EFAULT;
> > >
> > > + if (cmd.reason &&
> > > + cmd.reason != RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> > > + return -EINVAL;
> >
> > It would be clearer to set cmd.reason to IB_CM_REJ_CONSUMER_DEFINED at
> > this point..
> >
> > if (!cmd.reason)
> > cmd.reason = IB_CM_REJ_CONSUMER_DEFINED
> >
> > if (cmd.reason != IB_CM_REJ_CONSUMER_DEFINED && cmd.reason !=
> > RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> > return -EINVAL
> >
> > Esaier to follow and no reason userspace shouldn't be able to
> > explicitly specifiy the reason's that it is allowed to use.
> >
> >
> > > index 8d961d8b7cdb..f8781b132f62 100644
> > > +++ b/include/rdma/rdma_cm.h
> > > @@ -324,11 +324,12 @@ int __rdma_accept_ece(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
> > > */
> > > int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event);
> > >
> > > +
> > > /**
> >
> > Extra hunk?
> >
> > > * rdma_reject - Called to reject a connection request or response.
> > > */
> > > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > - u8 private_data_len);
> > > + u8 private_data_len, enum rdma_ucm_reject_reason reason);
> > >
> > > /**
> > > * rdma_disconnect - This function disconnects the associated QP and
> > > diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> > > index c4ca1412bcf9..e545f2de1e13 100644
> > > +++ b/include/uapi/rdma/rdma_user_cm.h
> > > @@ -78,6 +78,10 @@ enum rdma_ucm_port_space {
> > > RDMA_PS_UDP = 0x0111,
> > > };
> > >
> > > +enum rdma_ucm_reject_reason {
> > > + RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35
> > > +};
> >
> > not sure we need ABI defines for IBTA constants?
>
> Do you want to give an option to write any number?
> Right now, I'm enforcing only allowed by IBTA reason
> and which is used in user space.
no, just the allowed numbers, just wondering if we need constants for
fixed IBTA values ..
Jason
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason
2020-05-25 18:36 ` Jason Gunthorpe
@ 2020-05-26 5:49 ` Leon Romanovsky
0 siblings, 0 replies; 7+ messages in thread
From: Leon Romanovsky @ 2020-05-26 5:49 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: rds-devel, Bart Van Assche, Chaitanya Kulkarni, linux-rdma,
netdev, Santosh Shilimkar, linux-nvme, Christoph Hellwig,
Doug Ledford, target-devel, Jakub Kicinski, David S. Miller,
Sagi Grimberg
On Mon, May 25, 2020 at 03:36:47PM -0300, Jason Gunthorpe wrote:
> On Mon, May 25, 2020 at 09:22:42PM +0300, Leon Romanovsky wrote:
> > On Mon, May 25, 2020 at 03:14:17PM -0300, Jason Gunthorpe wrote:
> > > On Mon, Apr 13, 2020 at 05:15:38PM +0300, Leon Romanovsky wrote:
> > > > @@ -4223,7 +4223,7 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
> > > > EXPORT_SYMBOL(rdma_notify);
> > > >
> > > > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > > - u8 private_data_len)
> > > > + u8 private_data_len, enum rdma_ucm_reject_reason reason)
> > > > {
> > > > struct rdma_id_private *id_priv;
> > > > int ret;
> > > > @@ -4237,10 +4237,12 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > > ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,
> > > > private_data, private_data_len);
> > > > } else {
> > > > + enum ib_cm_rej_reason r =
> > > > + (reason) ?: IB_CM_REJ_CONSUMER_DEFINED;
> > > > +
> > > > trace_cm_send_rej(id_priv);
> > > > - ret = ib_send_cm_rej(id_priv->cm_id.ib,
> > > > - IB_CM_REJ_CONSUMER_DEFINED, NULL,
> > > > - 0, private_data, private_data_len);
> > > > + ret = ib_send_cm_rej(id_priv->cm_id.ib, r, NULL, 0,
> > > > + private_data, private_data_len);
> > > > }
> > > > } else if (rdma_cap_iw_cm(id->device, id->port_num)) {
> > > > ret = iw_cm_reject(id_priv->cm_id.iw,
> > > > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
> > > > index d41598954cc4..99482dc5934b 100644
> > > > +++ b/drivers/infiniband/core/ucma.c
> > > > @@ -1178,12 +1178,17 @@ static ssize_t ucma_reject(struct ucma_file *file, const char __user *inbuf,
> > > > if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
> > > > return -EFAULT;
> > > >
> > > > + if (cmd.reason &&
> > > > + cmd.reason != RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> > > > + return -EINVAL;
> > >
> > > It would be clearer to set cmd.reason to IB_CM_REJ_CONSUMER_DEFINED at
> > > this point..
> > >
> > > if (!cmd.reason)
> > > cmd.reason = IB_CM_REJ_CONSUMER_DEFINED
> > >
> > > if (cmd.reason != IB_CM_REJ_CONSUMER_DEFINED && cmd.reason !=
> > > RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED)
> > > return -EINVAL
> > >
> > > Esaier to follow and no reason userspace shouldn't be able to
> > > explicitly specifiy the reason's that it is allowed to use.
> > >
> > >
> > > > index 8d961d8b7cdb..f8781b132f62 100644
> > > > +++ b/include/rdma/rdma_cm.h
> > > > @@ -324,11 +324,12 @@ int __rdma_accept_ece(struct rdma_cm_id *id, struct rdma_conn_param *conn_param,
> > > > */
> > > > int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event);
> > > >
> > > > +
> > > > /**
> > >
> > > Extra hunk?
> > >
> > > > * rdma_reject - Called to reject a connection request or response.
> > > > */
> > > > int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > > > - u8 private_data_len);
> > > > + u8 private_data_len, enum rdma_ucm_reject_reason reason);
> > > >
> > > > /**
> > > > * rdma_disconnect - This function disconnects the associated QP and
> > > > diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> > > > index c4ca1412bcf9..e545f2de1e13 100644
> > > > +++ b/include/uapi/rdma/rdma_user_cm.h
> > > > @@ -78,6 +78,10 @@ enum rdma_ucm_port_space {
> > > > RDMA_PS_UDP = 0x0111,
> > > > };
> > > >
> > > > +enum rdma_ucm_reject_reason {
> > > > + RDMA_USER_CM_REJ_VENDOR_OPTION_NOT_SUPPORTED = 35
> > > > +};
> > >
> > > not sure we need ABI defines for IBTA constants?
> >
> > Do you want to give an option to write any number?
> > Right now, I'm enforcing only allowed by IBTA reason
> > and which is used in user space.
>
> no, just the allowed numbers, just wondering if we need constants for
> fixed IBTA values ..
I will take a look.
Thanks
>
> Jason
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-26 5:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 14:15 [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
2020-04-13 14:15 ` [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason Leon Romanovsky
2020-05-25 18:14 ` Jason Gunthorpe
2020-05-25 18:22 ` Leon Romanovsky
2020-05-25 18:36 ` Jason Gunthorpe
2020-05-26 5:49 ` Leon Romanovsky
2020-04-20 13:36 ` [PATCH rdma-next v2 0/7] Add Enhanced Connection Established (ECE) Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).