* [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0
[not found] <20200713122247.10985-1-refactormyself@gmail.com>
@ 2020-07-13 12:22 ` Saheed O. Bolarinwa
2020-07-13 16:42 ` Rajashekar, Revanth
2020-07-13 12:22 ` [RFC PATCH 10/35] nvme-pci: Tidy Success/Failure checks Saheed O. Bolarinwa
1 sibling, 1 reply; 4+ messages in thread
From: Saheed O. Bolarinwa @ 2020-07-13 12:22 UTC (permalink / raw)
To: helgaas, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Saheed O. Bolarinwa, skhan, linux-kernel, linux-nvme, linux-pci,
bjorn, linux-kernel-mentees
In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept.
Their scope should be limited within arch/x86.
Change all PCIBIOS_SUCCESSFUL to 0
Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index b1d18f0633c7..d426efb53f44 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1185,7 +1185,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)
result = pci_read_config_word(to_pci_dev(dev->dev), PCI_STATUS,
&pci_status);
- if (result == PCIBIOS_SUCCESSFUL)
+ if (result == 0)
dev_warn(dev->ctrl.device,
"controller is down; will reset: CSTS=0x%x, PCI_STATUS=0x%hx\n",
csts, pci_status);
--
2.18.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH 10/35] nvme-pci: Tidy Success/Failure checks
[not found] <20200713122247.10985-1-refactormyself@gmail.com>
2020-07-13 12:22 ` [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa
@ 2020-07-13 12:22 ` Saheed O. Bolarinwa
1 sibling, 0 replies; 4+ messages in thread
From: Saheed O. Bolarinwa @ 2020-07-13 12:22 UTC (permalink / raw)
To: helgaas, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Saheed O. Bolarinwa, skhan, linux-kernel, linux-nvme, linux-pci,
bjorn, linux-kernel-mentees
Remove unnecessary check for 0.
Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
---
This patch depends on PATCH 09/35
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d426efb53f44..a04f2d0375de 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1185,7 +1185,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)
result = pci_read_config_word(to_pci_dev(dev->dev), PCI_STATUS,
&pci_status);
- if (result == 0)
+ if (!result)
dev_warn(dev->ctrl.device,
"controller is down; will reset: CSTS=0x%x, PCI_STATUS=0x%hx\n",
csts, pci_status);
--
2.18.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0
2020-07-13 12:22 ` [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa
@ 2020-07-13 16:42 ` Rajashekar, Revanth
2020-07-13 18:24 ` Saheed Bolarinwa
0 siblings, 1 reply; 4+ messages in thread
From: Rajashekar, Revanth @ 2020-07-13 16:42 UTC (permalink / raw)
To: Saheed O. Bolarinwa, helgaas, Keith Busch, Jens Axboe,
Christoph Hellwig, Sagi Grimberg
Cc: linux-pci, linux-kernel, linux-nvme, skhan, bjorn, linux-kernel-mentees
Hi,
On 7/13/2020 6:22 AM, Saheed O. Bolarinwa wrote:
> In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept.
> Their scope should be limited within arch/x86.
>
> Change all PCIBIOS_SUCCESSFUL to 0
>
> Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index b1d18f0633c7..d426efb53f44 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1185,7 +1185,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)
>
> result = pci_read_config_word(to_pci_dev(dev->dev), PCI_STATUS,
> &pci_status);
> - if (result == PCIBIOS_SUCCESSFUL)
> + if (result == 0)
How about simplifying the check to if (!result)?
> dev_warn(dev->ctrl.device,
> "controller is down; will reset: CSTS=0x%x, PCI_STATUS=0x%hx\n",
> csts, pci_status);
Thanks!
Revanth
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0
2020-07-13 16:42 ` Rajashekar, Revanth
@ 2020-07-13 18:24 ` Saheed Bolarinwa
0 siblings, 0 replies; 4+ messages in thread
From: Saheed Bolarinwa @ 2020-07-13 18:24 UTC (permalink / raw)
To: Rajashekar, Revanth, helgaas, Keith Busch, Jens Axboe,
Christoph Hellwig, Sagi Grimberg
Cc: linux-pci, linux-kernel, linux-nvme, skhan, bjorn, linux-kernel-mentees
On 7/13/20 6:42 PM, Rajashekar, Revanth wrote:
> Hi,
>
> On 7/13/2020 6:22 AM, Saheed O. Bolarinwa wrote:
>> In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept.
>> Their scope should be limited within arch/x86.
>>
>> Change all PCIBIOS_SUCCESSFUL to 0
>>
>> Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
>> ---
>> drivers/nvme/host/pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>> index b1d18f0633c7..d426efb53f44 100644
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -1185,7 +1185,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)
>>
>> result = pci_read_config_word(to_pci_dev(dev->dev), PCI_STATUS,
>> &pci_status);
>> - if (result == PCIBIOS_SUCCESSFUL)
>> + if (result == 0)
> How about simplifying the check to if (!result)?
Thank you for the review. I did in PATCH 10/35. I will merge both.
I wanted to separate the goal from the fix but I see it's confusing.
- Saheed
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200713122247.10985-1-refactormyself@gmail.com>
2020-07-13 12:22 ` [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa
2020-07-13 16:42 ` Rajashekar, Revanth
2020-07-13 18:24 ` Saheed Bolarinwa
2020-07-13 12:22 ` [RFC PATCH 10/35] nvme-pci: Tidy Success/Failure checks Saheed O. Bolarinwa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).