[PATCH] nvme-fc: soften messages logged by error_recovery

[PATCH] nvme-fc: soften messages logged by error_recovery

[James Smart]

Several of the messages logged vi nvme_fc_error_recovery() come across
as rather strong events due to the use of the word "error". This is
causing some interpretations to be overly worried.

Soften the wording of the messages.

Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/nvme/host/fc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index e8ef42b9d50c..bc4e1af587cc 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2433,7 +2433,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg)
 		return;
 
 	dev_warn(ctrl->ctrl.device,
-		"NVME-FC{%d}: transport association error detected: %s\n",
+		"NVME-FC{%d}: transport association event: %s\n",
 		ctrl->cnum, errmsg);
 	dev_warn(ctrl->ctrl.device,
 		"NVME-FC{%d}: resetting controller\n", ctrl->cnum);
@@ -2454,7 +2454,7 @@ nvme_fc_timeout(struct request *rq, bool reserved)
 	 * the host/io stack, terminate the association on the link,
 	 * and recreate an association on the link.
 	 */
-	nvme_fc_error_recovery(ctrl, "io timeout error");
+	nvme_fc_error_recovery(ctrl, "io timeout");
 
 	/*
 	 * the io abort has been initiated. Have the reset timer
-- 
2.26.2


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-fc: soften messages logged by error_recovery

[Himanshu Madhani]

> On Sep 11, 2020, at 3:02 PM, James Smart <james.smart@broadcom.com> wrote:
> 
> Several of the messages logged vi nvme_fc_error_recovery() come across
> as rather strong events due to the use of the word "error". This is
> causing some interpretations to be overly worried.
> 
> Soften the wording of the messages.
> 
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
> drivers/nvme/host/fc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index e8ef42b9d50c..bc4e1af587cc 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -2433,7 +2433,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg)
> 		return;
> 
> 	dev_warn(ctrl->ctrl.device,
> -		"NVME-FC{%d}: transport association error detected: %s\n",
> +		"NVME-FC{%d}: transport association event: %s\n",
> 		ctrl->cnum, errmsg);
> 	dev_warn(ctrl->ctrl.device,
> 		"NVME-FC{%d}: resetting controller\n", ctrl->cnum);
> @@ -2454,7 +2454,7 @@ nvme_fc_timeout(struct request *rq, bool reserved)
> 	 * the host/io stack, terminate the association on the link,
> 	 * and recreate an association on the link.
> 	 */
> -	nvme_fc_error_recovery(ctrl, "io timeout error");
> +	nvme_fc_error_recovery(ctrl, "io timeout");
> 
> 	/*
> 	 * the io abort has been initiated. Have the reset timer
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme


Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-fc: soften messages logged by error_recovery

[Christoph Hellwig]

Both hunk fail to apply to the current tree.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme