* [PATCH] fabrics: permit kato int argument for discovery controllers
@ 2021-02-18 9:46 Martin George
2021-02-18 16:29 ` Hannes Reinecke
0 siblings, 1 reply; 3+ messages in thread
From: Martin George @ 2021-02-18 9:46 UTC (permalink / raw)
To: linux-nvme; +Cc: Martin George
Given discovery controllers can now accept integer arguments
for kato, permit the same in build_options().
Signed-off-by: Martin George <marting@netapp.com>
---
fabrics.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fabrics.c b/fabrics.c
index 1880a5d..9cfe26a 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -896,9 +896,8 @@ static int build_options(char *argstr, int max_len, bool discover)
(!discover &&
add_int_argument(&argstr, &max_len, "queue_size",
cfg.queue_size, false)) ||
- (!discover &&
- add_int_argument(&argstr, &max_len, "keep_alive_tmo",
- cfg.keep_alive_tmo, false)) ||
+ add_int_argument(&argstr, &max_len, "keep_alive_tmo",
+ cfg.keep_alive_tmo, false) ||
add_int_argument(&argstr, &max_len, "reconnect_delay",
cfg.reconnect_delay, false) ||
add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
--
2.30.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fabrics: permit kato int argument for discovery controllers
2021-02-18 9:46 [PATCH] fabrics: permit kato int argument for discovery controllers Martin George
@ 2021-02-18 16:29 ` Hannes Reinecke
2021-02-18 16:36 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Hannes Reinecke @ 2021-02-18 16:29 UTC (permalink / raw)
To: Martin George, linux-nvme; +Cc: Martin George
On 2/18/21 10:46 AM, Martin George wrote:
> Given discovery controllers can now accept integer arguments
> for kato, permit the same in build_options().
>
> Signed-off-by: Martin George <marting@netapp.com>
> ---
> fabrics.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fabrics.c b/fabrics.c
> index 1880a5d..9cfe26a 100644
> --- a/fabrics.c
> +++ b/fabrics.c
> @@ -896,9 +896,8 @@ static int build_options(char *argstr, int max_len, bool discover)
> (!discover &&
> add_int_argument(&argstr, &max_len, "queue_size",
> cfg.queue_size, false)) ||
> - (!discover &&
> - add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> - cfg.keep_alive_tmo, false)) ||
> + add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> + cfg.keep_alive_tmo, false) ||
> add_int_argument(&argstr, &max_len, "reconnect_delay",
> cfg.reconnect_delay, false) ||
> add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Martin, you probably have to resend it via a pull request to the github
repository.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fabrics: permit kato int argument for discovery controllers
2021-02-18 16:29 ` Hannes Reinecke
@ 2021-02-18 16:36 ` Keith Busch
0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2021-02-18 16:36 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: Martin George, Martin George, linux-nvme
On Thu, Feb 18, 2021 at 05:29:27PM +0100, Hannes Reinecke wrote:
> On 2/18/21 10:46 AM, Martin George wrote:
> > Given discovery controllers can now accept integer arguments
> > for kato, permit the same in build_options().
> >
> > Signed-off-by: Martin George <marting@netapp.com>
> > ---
> > fabrics.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/fabrics.c b/fabrics.c
> > index 1880a5d..9cfe26a 100644
> > --- a/fabrics.c
> > +++ b/fabrics.c
> > @@ -896,9 +896,8 @@ static int build_options(char *argstr, int max_len, bool discover)
> > (!discover &&
> > add_int_argument(&argstr, &max_len, "queue_size",
> > cfg.queue_size, false)) ||
> > - (!discover &&
> > - add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> > - cfg.keep_alive_tmo, false)) ||
> > + add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> > + cfg.keep_alive_tmo, false) ||
> > add_int_argument(&argstr, &max_len, "reconnect_delay",
> > cfg.reconnect_delay, false) ||
> > add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
> >
> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Martin, you probably have to resend it via a pull request to the github
> repository.
Not necessary, I am totally okay with applying these direct from the
mailing list.
Thanks for the review, patch is already applied!
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-18 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 9:46 [PATCH] fabrics: permit kato int argument for discovery controllers Martin George
2021-02-18 16:29 ` Hannes Reinecke
2021-02-18 16:36 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).