* [PATCH] nvme: Add quirks for Lexar 256GB SSD
@ 2021-02-23 22:10 Pascal Terjan
2021-02-24 7:21 ` Chaitanya Kulkarni
2021-02-24 9:21 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Pascal Terjan @ 2021-02-23 22:10 UTC (permalink / raw)
To: linux-nvme; +Cc: Pascal Terjan
Add NVME_QUIRK_NO_NS_DESC_LIST to Lexar 256GB SSD to allow it to
work again, and add NVME_QUIRK_IGNORE_DEV_SUBNQN to avoid a warning.
[ 0.637476] nvme nvme0: missing or invalid SUBNQN field.
[ 0.638399] nvme nvme0: Identify Descriptors failed (16386)
Reported and tested in https://bugs.mageia.org/show_bug.cgi?id=28417
Signed-off-by: Pascal Terjan <pterjan@google.com>
---
drivers/nvme/host/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7b6632c00ffd..9a56ec70e93a 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3232,6 +3232,9 @@ static const struct pci_device_id nvme_id_table[] = {
NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
+ { PCI_DEVICE(0x1b4b, 0x1092), /* Lexar 256 GB SSD */
+ .driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
+ NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
--
2.30.0.617.g56c4b15f3c-goog
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] nvme: Add quirks for Lexar 256GB SSD
2021-02-23 22:10 [PATCH] nvme: Add quirks for Lexar 256GB SSD Pascal Terjan
@ 2021-02-24 7:21 ` Chaitanya Kulkarni
2021-02-24 9:21 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-24 7:21 UTC (permalink / raw)
To: Pascal Terjan; +Cc: linux-nvme
Pascal,
On 2/23/21 14:15, Pascal Terjan wrote:
> Add NVME_QUIRK_NO_NS_DESC_LIST to Lexar 256GB SSD to allow it to
> work again, and add NVME_QUIRK_IGNORE_DEV_SUBNQN to avoid a warning.
>
> [ 0.637476] nvme nvme0: missing or invalid SUBNQN field.
> [ 0.638399] nvme nvme0: Identify Descriptors failed (16386)
>
> Reported and tested in https://bugs.mageia.org/show_bug.cgi?id=28417
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>
Do we need to add the Tested-by: tag ? if this is tested by other than the
patch author ?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Add quirks for Lexar 256GB SSD
2021-02-23 22:10 [PATCH] nvme: Add quirks for Lexar 256GB SSD Pascal Terjan
2021-02-24 7:21 ` Chaitanya Kulkarni
@ 2021-02-24 9:21 ` Christoph Hellwig
2021-02-24 10:23 ` Pascal Terjan
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2021-02-24 9:21 UTC (permalink / raw)
To: Pascal Terjan; +Cc: linux-nvme
On Tue, Feb 23, 2021 at 10:10:46PM +0000, Pascal Terjan wrote:
> Add NVME_QUIRK_NO_NS_DESC_LIST to Lexar 256GB SSD to allow it to
> work again, and add NVME_QUIRK_IGNORE_DEV_SUBNQN to avoid a warning.
Why again? The drive has always been broken since the desc list has
been a mandatory feature since NVMe 1.3..
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Add quirks for Lexar 256GB SSD
2021-02-24 9:21 ` Christoph Hellwig
@ 2021-02-24 10:23 ` Pascal Terjan
2021-02-25 16:22 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: Pascal Terjan @ 2021-02-24 10:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-nvme
On Wed, 24 Feb 2021 at 09:21, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Feb 23, 2021 at 10:10:46PM +0000, Pascal Terjan wrote:
> > Add NVME_QUIRK_NO_NS_DESC_LIST to Lexar 256GB SSD to allow it to
> > work again, and add NVME_QUIRK_IGNORE_DEV_SUBNQN to avoid a warning.
>
> Why again? The drive has always been broken since the desc list has
> been a mandatory feature since NVMe 1.3..
According to the reporter it works on Debian which is still running a
4.19 kernel
My guess is that it worked before
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=538af88ea7d9de241e6b6f006e9049c4d96723bb
as the error was ignored
And I believe it would have worked again until
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5bedd3afee8eb01ccd256f0cd2cc0fa6f841417a
as a waorkaround was added at some point (it changed at
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb314eb0cbb2e11540d1ae1a7b28346397f621ef
but was laready there)
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Add quirks for Lexar 256GB SSD
2021-02-24 10:23 ` Pascal Terjan
@ 2021-02-25 16:22 ` Keith Busch
0 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2021-02-25 16:22 UTC (permalink / raw)
To: Pascal Terjan; +Cc: Christoph Hellwig, linux-nvme
On Wed, Feb 24, 2021 at 10:23:23AM +0000, Pascal Terjan wrote:
> On Wed, 24 Feb 2021 at 09:21, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:10:46PM +0000, Pascal Terjan wrote:
> > > Add NVME_QUIRK_NO_NS_DESC_LIST to Lexar 256GB SSD to allow it to
> > > work again, and add NVME_QUIRK_IGNORE_DEV_SUBNQN to avoid a warning.
> >
> > Why again? The drive has always been broken since the desc list has
> > been a mandatory feature since NVMe 1.3..
>
> According to the reporter it works on Debian which is still running a
> 4.19 kernel
> My guess is that it worked before
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=538af88ea7d9de241e6b6f006e9049c4d96723bb
> as the error was ignored
> And I believe it would have worked again until
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5bedd3afee8eb01ccd256f0cd2cc0fa6f841417a
> as a waorkaround was added at some point (it changed at
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb314eb0cbb2e11540d1ae1a7b28346397f621ef
> but was laready there)
Right, the error used to be ignored, but now we avoid the error in the
first place with the quirk.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-25 16:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 22:10 [PATCH] nvme: Add quirks for Lexar 256GB SSD Pascal Terjan
2021-02-24 7:21 ` Chaitanya Kulkarni
2021-02-24 9:21 ` Christoph Hellwig
2021-02-24 10:23 ` Pascal Terjan
2021-02-25 16:22 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).