From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Vidya Sagar <vidyas@nvidia.com>
Subject: Re: [PATCH] nvme/pci: default to simple suspend
Date: Tue, 8 Feb 2022 09:14:21 -0800 [thread overview]
Message-ID: <20220208171421.GA1168214@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20220208143751.GA25260@lst.de>
On Tue, Feb 08, 2022 at 03:37:51PM +0100, Christoph Hellwig wrote:
> On Mon, Feb 07, 2022 at 08:06:55AM -0800, Keith Busch wrote:
> > > I'd really prefer to sort this out at the platform level. We can't work
> > > around broken platforms in nvme forever.
> >
> > I agree, but I'm not sure how to get everyone aligned.
> >
> > How about this to resolve the regressions: if the platform doesn't
> > provide StorageD3Enable property, can we just default to the simple
> > shutdown method? We'd only use the nvme power management capabilities if
> > the platform explicity says it doesn't want D3, making the default the
> > same as the legacy behavior.
>
> I don't think this will work, as most older platforms just won't have
> that attribute at all, and non-ACPI platforms most certainly won't have
> it. We'll need more quirks in the core PCI/PM code like we did for the
> AMD mobile platforms.
old platform + old kernel -> simple suspend
old platform + new kernel -> nvme pm
This inevitably introduced regressions. Why should we need to quirk old
platforms for a feature that didn't even exist when they were made?
Shouldn't the quirk be the other way around?
next prev parent reply other threads:[~2022-02-08 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 16:50 [PATCH] nvme/pci: default to simple suspend Keith Busch
2022-02-01 17:49 ` Vidya Sagar
2022-02-02 7:55 ` Christoph Hellwig
2022-02-02 16:03 ` Keith Busch
2022-02-04 7:10 ` Christoph Hellwig
2022-02-07 16:06 ` Keith Busch
2022-02-08 14:37 ` Christoph Hellwig
2022-02-08 17:14 ` Keith Busch [this message]
2022-02-09 7:48 ` Christoph Hellwig
2022-04-11 13:58 ` Manivannan Sadhasivam
2022-04-23 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208171421.GA1168214@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sagi@grimberg.me \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).