Re: [PATCH v1] nvme: do not log errors for user commands

From: Daniel Wagner <dwagner@suse.de>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: Pankaj Raghav <pankydev8@gmail.com>,
	"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
	Keith Busch <kbusch@kernel.org>, Yi Zhang <yi.zhang@redhat.com>,
	Tomas Bzatek <tbzatek@redhat.com>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Martin Petersen <martin.petersen@oracle.com>,
	"gost.dev@samsung.com" <gost.dev@samsung.com>,
	Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v1] nvme: do not log errors for user commands
Date: Mon, 10 Oct 2022 09:36:04 +0200	[thread overview]
Message-ID: <20221010073604.rryji23gnnxgoqrr@carbon.lan> (raw)
In-Reply-To: <35A47E59-90E0-4F6C-80EA-A98F59213FA0@oracle.com>

Hi Alan,

On Fri, Oct 07, 2022 at 09:19:08PM +0000, Alan Adamson wrote:
> > I do get the debugging argument, but this clearly regresses production
> > code. Ideally, this code should be opt-in. The only way I see how to make
> > this work is by introducing a new API which allows enable this
> > feature.
> 
> Looks like a new API may need to be created.  I’ll investigate that.
> With your change, there will need to be a blktests change.

Thanks for picking this up.

> nvme/039 => nvme0n1 (test error logging)                     [failed]
>     runtime  0.120s  ...  0.118s
>     --- tests/nvme/039.out	2022-09-21 17:14:12.760890663 -0400
>     +++ /root/blktests/results/nvme0n1/nvme/039.out.bad	2022-10-06 19:11:45.846879996 -0400
>     @@ -2,6 +2,4 @@
>       Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR 
>       Read(0x2) @ LBA 0, 1 blocks, Unknown (sct 0x3 / sc 0x75) DNR 
>       Write(0x1) @ LBA 0, 1 blocks, Write Fault (sct 0x2 / sc 0x80) DNR 
>     - Identify(0x6), Access Denied (sct 0x2 / sc 0x86) DNR 
>     - Unknown(0x96), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR 
>      Test complete

Hmm, that is not supposed to happen. Well, obviously this needs some
more work :)

Thanks,
Daniel