From: Alan Adamson <alan.adamson@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Daniel Wagner <dwagner@suse.de>,
Pankaj Raghav <pankydev8@gmail.com>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
Yi Zhang <yi.zhang@redhat.com>, Tomas Bzatek <tbzatek@redhat.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Martin Petersen <martin.petersen@oracle.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v1] nvme: do not log errors for user commands
Date: Mon, 17 Oct 2022 16:40:25 +0000 [thread overview]
Message-ID: <79E937D0-58DA-4AE2-A0B8-A30185CE7FCE@oracle.com> (raw)
In-Reply-To: <Y02E5PjYfdwjJdez@kbusch-mbp.dhcp.thefacebook.com>
> On Oct 17, 2022, at 9:37 AM, Keith Busch <kbusch@kernel.org> wrote:
>
> On Mon, Oct 17, 2022 at 12:07:33AM -0700, Christoph Hellwig wrote:
>> On Fri, Oct 07, 2022 at 09:19:08PM +0000, Alan Adamson wrote:
>>>> I do get the debugging argument, but this clearly regresses production
>>>> code. Ideally, this code should be opt-in. The only way I see how to make
>>>> this work is by introducing a new API which allows enable this
>>>> feature.
>>>
>>> Looks like a new API may need to be created. I’ll investigate that.
>>> With your change, there
>>> will need to be a blktests change.
>>
>> Yes, I think we need to effectively revert this for user commands and
>> then add an opt in - be that from the submitter, or through a sysfs
>> file for all command.
>
> Yeah, I think we should revert logging errors for user admin commands
> (io command logs can probably remain). There are tools running at
> regular intervals that query all devices for optional pages, and
> spamming the kernel logs with these repeated errors is causing some
> problems.
I agree. I’ll look into a being able to opt in to logging of admin commands.
Alan
prev parent reply other threads:[~2022-10-17 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:36 [PATCH v1] nvme: do not log errors for user commands Daniel Wagner
2022-10-06 12:16 ` Pankaj Raghav
2022-10-06 13:30 ` Daniel Wagner
2022-10-07 21:19 ` Alan Adamson
2022-10-10 7:36 ` Daniel Wagner
2022-10-17 7:07 ` Christoph Hellwig
2022-10-17 16:37 ` Keith Busch
2022-10-17 16:40 ` Alan Adamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79E937D0-58DA-4AE2-A0B8-A30185CE7FCE@oracle.com \
--to=alan.adamson@oracle.com \
--cc=dwagner@suse.de \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=tbzatek@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).