[PATCH] nvme: change shutdown timeout setting message

[PATCH] nvme: change shutdown timeout setting message

[Keith Busch]

From: Keith Busch <kbusch@kernel.org>

User visible messages containing the word "timeout" can be alarming.
This one nvme is just reporting a potentially informative device
configuration, and everything is working as designed. Change the text to
report the less concerning "D3 entry latency", which is where this value
comes from anyway.

Reported-by: Len Brown <lenb@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 2baf5786a92fe..0dcaf3973dc49 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3233,7 +3233,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
 
 		if (ctrl->shutdown_timeout != shutdown_timeout)
 			dev_info(ctrl->device,
-				 "Shutdown timeout set to %u seconds\n",
+				 "D3 entry latency set to %u seconds\n",
 				 ctrl->shutdown_timeout);
 	} else
 		ctrl->shutdown_timeout = shutdown_timeout;
-- 
2.34.1

Re: [PATCH] nvme: change shutdown timeout setting message

[Chaitanya Kulkarni]

On 3/7/24 08:59, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> User visible messages containing the word "timeout" can be alarming.
> This one nvme is just reporting a potentially informative device
> configuration, and everything is working as designed. Change the text to
> report the less concerning "D3 entry latency", which is where this value
> comes from anyway.
>
> Reported-by: Len Brown <lenb@kernel.org>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] nvme: change shutdown timeout setting message

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Re: [PATCH] nvme: change shutdown timeout setting message

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>