From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org
Cc: oren@nvidia.com, chaitanyak@nvidia.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nvme: use macro definitions for setting reservation values
Date: Mon, 3 Oct 2022 13:16:36 +0300 [thread overview]
Message-ID: <3354c32d-34b3-0997-3a59-8fc199e6640a@nvidia.com> (raw)
In-Reply-To: <cfd01d2e-1f87-2295-13bb-c8705b3335f9@grimberg.me>
On 10/3/2022 1:03 PM, Sagi Grimberg wrote:
>
>> This makes the code more readable.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>> Changes from v1:
>> - remove comments (Sagi/Keith)
>> - use tabs for constants alignment, similar to 'enum pr_type' (Keith)
>> ---
>> drivers/nvme/host/core.c | 12 ++++++------
>> include/linux/nvme.h | 9 +++++++++
>> 2 files changed, 15 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 3f1a7dc2a2a3..50668e1bd9f1 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -2068,17 +2068,17 @@ static char nvme_pr_type(enum pr_type type)
>> {
>> switch (type) {
>> case PR_WRITE_EXCLUSIVE:
>> - return 1;
>> + return NVME_PR_WRITE_EXCLUSIVE;
>> case PR_EXCLUSIVE_ACCESS:
>> - return 2;
>> + return NVME_PR_EXCLUSIVE_ACCESS;
>> case PR_WRITE_EXCLUSIVE_REG_ONLY:
>> - return 3;
>> + return NVME_PR_WRITE_EXCLUSIVE_REG_ONLY;
>> case PR_EXCLUSIVE_ACCESS_REG_ONLY:
>> - return 4;
>> + return NVME_PR_EXCLUSIVE_ACCESS_REG_ONLY;
>> case PR_WRITE_EXCLUSIVE_ALL_REGS:
>> - return 5;
>> + return NVME_PR_WRITE_EXCLUSIVE_ALL_REGS;
>> case PR_EXCLUSIVE_ACCESS_ALL_REGS:
>> - return 6;
>> + return NVME_PR_EXCLUSIVE_ACCESS_ALL_REGS;
>> default:
>> return 0;
>> }
>> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
>> index ae53d74f3696..4f777d8621a7 100644
>> --- a/include/linux/nvme.h
>> +++ b/include/linux/nvme.h
>> @@ -238,6 +238,15 @@ enum {
>> NVME_CAP_CRMS_CRIMS = 1ULL << 60,
>> };
>> +enum {
>
> I'd make this named nvme_pr_type
Most of the enums of this header are not named.
I don't understand what is the convention here.
Usually, if it's not a new header file I'm trying to keep the file
convention and this is what I did.
If all agree on named, I'll send another version.
next prev parent reply other threads:[~2022-10-03 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 8:28 [PATCH v2 1/1] nvme: use macro definitions for setting reservation values Max Gurtovoy
2022-10-03 10:03 ` Sagi Grimberg
2022-10-03 10:16 ` Max Gurtovoy [this message]
2022-10-25 15:19 ` Christoph Hellwig
2022-10-25 23:09 ` Keith Busch
2022-10-28 8:31 ` Christoph Hellwig
2022-10-30 0:35 ` Max Gurtovoy
2022-10-25 23:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3354c32d-34b3-0997-3a59-8fc199e6640a@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).