From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, oren@nvidia.com,
chaitanyak@nvidia.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nvme: use macro definitions for setting reservation values
Date: Tue, 25 Oct 2022 17:09:21 -0600 [thread overview]
Message-ID: <Y1hsoZNjDMhDbemd@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20221025151914.GA23422@lst.de>
On Tue, Oct 25, 2022 at 05:19:14PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 03, 2022 at 01:16:36PM +0300, Max Gurtovoy wrote:
> >> I'd make this named nvme_pr_type
> >
> > Most of the enums of this header are not named.
> >
> > I don't understand what is the convention here.
> >
> > Usually, if it's not a new header file I'm trying to keep the file
> > convention and this is what I did.
> >
> > If all agree on named, I'll send another version.
>
> I think named is better, nvme has some weird unnamed enums that
> even combine totally unrelated fields which I always found confusing.
It's carry-over from the early days when structures had so few constants
that giving each field values their own enum looked a bit silly, and
enums were considered better than a bunch of #define's.
As far as naming them goes, if the only usage is its definition, then
what's the point? If there's a use for a named enum somewhere else, then
yah, that improves readability.
next prev parent reply other threads:[~2022-10-25 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 8:28 [PATCH v2 1/1] nvme: use macro definitions for setting reservation values Max Gurtovoy
2022-10-03 10:03 ` Sagi Grimberg
2022-10-03 10:16 ` Max Gurtovoy
2022-10-25 15:19 ` Christoph Hellwig
2022-10-25 23:09 ` Keith Busch [this message]
2022-10-28 8:31 ` Christoph Hellwig
2022-10-30 0:35 ` Max Gurtovoy
2022-10-25 23:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1hsoZNjDMhDbemd@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).