From: Hannes Reinecke <hare@suse.de>
To: John Meneghini <jmeneghi@redhat.com>,
"Knight, Frederick" <Frederick.Knight@netapp.com>,
Daniel Wagner <dwagner@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v2] nvmet: force reconnect when number of queue changes
Date: Fri, 30 Sep 2022 09:03:55 +0200 [thread overview]
Message-ID: <36289eb9-2605-8461-a414-fea5e4ed1211@suse.de> (raw)
In-Reply-To: <410aeb5c-3045-59ac-3fc8-fe80a89b9119@redhat.com>
On 9/29/22 04:14, John Meneghini wrote:
> On 9/28/22 14:02, Knight, Frederick wrote:
>> Reset and Disconnect are different.
>>
>> Reset uses registers (and therefore Get Property and Set Property
>> commands) over a valid connection.
>>
>> Disconnect causes a reset (you have to reconnect to the reset controller)
>> Reset does not cause an immediate disconnect.
>
> OK, so you are saying that the rule "The controller shall not change the
> value allocated between resets" in NVMe 5.27.1.5 doesn't apply to fabric
> controllers?
>
No; problem is that the linux usage of the word 'reset' really is a
disconnect/reconnect (for which a queue change is allowed); we never to
a NVMe reset via Get/Set Properties for fabrics.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2022-09-30 7:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 14:31 [PATCH v2] nvmet: force reconnect when number of queue changes Daniel Wagner
2022-09-27 15:01 ` Daniel Wagner
2022-09-28 6:55 ` Sagi Grimberg
2022-09-28 7:48 ` Daniel Wagner
2022-09-28 8:31 ` Sagi Grimberg
2022-09-28 9:02 ` Daniel Wagner
2022-09-28 12:39 ` Knight, Frederick
2022-09-28 13:50 ` Daniel Wagner
2022-09-28 14:23 ` Sagi Grimberg
2022-09-28 15:21 ` Hannes Reinecke
2022-09-28 16:01 ` Knight, Frederick
2022-10-05 18:15 ` Daniel Wagner
2022-10-06 11:37 ` Sagi Grimberg
2022-10-06 20:15 ` James Smart
2022-10-06 20:54 ` Knight, Frederick
2022-09-28 16:01 ` Knight, Frederick
2022-09-28 15:01 ` John Meneghini
2022-09-28 15:26 ` Daniel Wagner
2022-09-28 18:02 ` Knight, Frederick
2022-09-29 2:14 ` John Meneghini
2022-09-29 3:04 ` Knight, Frederick
2022-09-30 7:03 ` Hannes Reinecke [this message]
2022-09-30 6:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36289eb9-2605-8461-a414-fea5e4ed1211@suse.de \
--to=hare@suse.de \
--cc=Frederick.Knight@netapp.com \
--cc=dwagner@suse.de \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).