From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "joshi.k@samsung.com" <joshi.k@samsung.com>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCHv2 1/2] nvme-pci: allocate nvme_command within driver pdu
Date: Wed, 17 Mar 2021 21:39:39 +0000 [thread overview]
Message-ID: <3E3552A0-3932-4EE4-A30F-E1296503CC2E@oracle.com> (raw)
In-Reply-To: <20210317203703.17391-2-kbusch@kernel.org>
> On Mar 17, 2021, at 3:37 PM, Keith Busch <kbusch@kernel.org> wrote:
>
> Except for pci, all the nvme transport drivers allocate a command within
> the driver's pdu. Align pci with everyone else by allocating the nvme
> command within pci's pdu and replace the .queue_rq() stack variable with
> this.
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/pci.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index ecd11b1febf8..1a0912146c74 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -224,6 +224,7 @@ struct nvme_queue {
> */
> struct nvme_iod {
> struct nvme_request req;
> + struct nvme_command cmd;
> struct nvme_queue *nvmeq;
> bool use_sgl;
> int aborted;
> @@ -917,7 +918,7 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
> struct nvme_dev *dev = nvmeq->dev;
> struct request *req = bd->rq;
> struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
> - struct nvme_command cmnd;
> + struct nvme_command *cmnd = &iod->cmd;
> blk_status_t ret;
>
> iod->aborted = 0;
> @@ -931,24 +932,24 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
> if (unlikely(!test_bit(NVMEQ_ENABLED, &nvmeq->flags)))
> return BLK_STS_IOERR;
>
> - ret = nvme_setup_cmd(ns, req, &cmnd);
> + ret = nvme_setup_cmd(ns, req, cmnd);
> if (ret)
> return ret;
>
> if (blk_rq_nr_phys_segments(req)) {
> - ret = nvme_map_data(dev, req, &cmnd);
> + ret = nvme_map_data(dev, req, cmnd);
> if (ret)
> goto out_free_cmd;
> }
>
> if (blk_integrity_rq(req)) {
> - ret = nvme_map_metadata(dev, req, &cmnd);
> + ret = nvme_map_metadata(dev, req, cmnd);
> if (ret)
> goto out_unmap_data;
> }
>
> blk_mq_start_request(req);
> - nvme_submit_cmd(nvmeq, &cmnd, bd->last);
> + nvme_submit_cmd(nvmeq, cmnd, bd->last);
> return BLK_STS_OK;
> out_unmap_data:
> nvme_unmap_data(dev, req);
> --
> 2.25.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks Good
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-17 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:37 [PATCHv2 0/2] nvme driver pdu enhancements for passthrough Keith Busch
2021-03-17 20:37 ` [PATCHv2 1/2] nvme-pci: allocate nvme_command within driver pdu Keith Busch
2021-03-17 21:39 ` Himanshu Madhani [this message]
2021-03-18 1:08 ` Chaitanya Kulkarni
2021-03-18 5:27 ` Kanchan Joshi
2021-03-17 20:37 ` [PATCHv2 2/2] nvme: use driver pdu command for passthrough Keith Busch
2021-03-17 21:39 ` Himanshu Madhani
2021-03-17 22:21 ` Sagi Grimberg
2021-03-18 2:00 ` [PATCHv2 0/2] nvme driver pdu enhancements " Jens Axboe
2021-03-18 5:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E3552A0-3932-4EE4-A30F-E1296503CC2E@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).