From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>,
joshi.k@samsung.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv2 0/2] nvme driver pdu enhancements for passthrough
Date: Wed, 17 Mar 2021 20:00:30 -0600 [thread overview]
Message-ID: <8a7b7a34-0001-c470-7c11-a15df71f4d89@kernel.dk> (raw)
In-Reply-To: <20210317203703.17391-1-kbusch@kernel.org>
On 3/17/21 2:37 PM, Keith Busch wrote:
> v1->v2:
>
> Improved change logs, added reviews.
>
> Retain clearing SGL in passthrough commands (hch)
>
> Added a comment explaining why REQ_OP_DRV_IN/OUT is a no-op for
> nvme_setup_cmd()
>
> Keith Busch (2):
> nvme-pci: allocate nvme_command within driver pdu
> nvme: use driver pdu command for passthrough
>
> drivers/nvme/host/core.c | 23 ++++++++++-------------
> drivers/nvme/host/fc.c | 5 ++---
> drivers/nvme/host/nvme.h | 3 +--
> drivers/nvme/host/pci.c | 12 +++++++-----
> drivers/nvme/host/rdma.c | 5 +++--
> drivers/nvme/host/tcp.c | 5 ++++-
> drivers/nvme/target/loop.c | 4 +++-
> 7 files changed, 30 insertions(+), 27 deletions(-)
These are both nice.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-18 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:37 [PATCHv2 0/2] nvme driver pdu enhancements for passthrough Keith Busch
2021-03-17 20:37 ` [PATCHv2 1/2] nvme-pci: allocate nvme_command within driver pdu Keith Busch
2021-03-17 21:39 ` Himanshu Madhani
2021-03-18 1:08 ` Chaitanya Kulkarni
2021-03-18 5:27 ` Kanchan Joshi
2021-03-17 20:37 ` [PATCHv2 2/2] nvme: use driver pdu command for passthrough Keith Busch
2021-03-17 21:39 ` Himanshu Madhani
2021-03-17 22:21 ` Sagi Grimberg
2021-03-18 2:00 ` Jens Axboe [this message]
2021-03-18 5:18 ` [PATCHv2 0/2] nvme driver pdu enhancements " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a7b7a34-0001-c470-7c11-a15df71f4d89@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).