From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org
Subject: Re: [PATCH] nvme-cli: remove default ctrl_loss_tmo for connect
Date: Fri, 23 Oct 2020 14:13:57 -0700 [thread overview]
Message-ID: <58b2a430-4ea8-174e-ab7c-ce93d45c4bc2@grimberg.me> (raw)
In-Reply-To: <20201023202521.9610-1-chaitanya.kulkarni@wdc.com>
> Since nvme-cli adds a default ctrl_loss_tmo for connect command
> all the testcases in the blktests are failing. Thjs addition of
> the parameter breaks the nvme-cli command-line compatibility with older
> versions.
>
> Remove the default ctrl loss tmo parameter addition for the connect
> command user can specify that from the command line.
Please CC the patch author that made ctrl_loss_tmo to be passed
by default, the patch description provided does not specify
a good reason why the patch was given.
Also, please add a Fixes: tag.
--
commit 4b607779af71d23bc5ff7fcc14a7e1fde8507ed7
Author: Aleksei Marov <alekseymmm@mail.ru>
Date: Fri Jun 19 18:10:07 2020 +0300
Allow 0 value of ctrl_loss_tmo.
--
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-23 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 20:25 [PATCH] nvme-cli: remove default ctrl_loss_tmo for connect Chaitanya Kulkarni
2020-10-23 21:13 ` Sagi Grimberg [this message]
2020-10-23 21:16 ` Sagi Grimberg
2020-10-26 21:02 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b2a430-4ea8-174e-ab7c-ce93d45c4bc2@grimberg.me \
--to=sagi@grimberg.me \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).