linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-cli: remove default ctrl_loss_tmo for connect
Date: Mon, 26 Oct 2020 21:02:53 +0000	[thread overview]
Message-ID: <BYAPR04MB4965DB3544F102E75DE05DB486190@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 5c212507-d518-5343-3836-93107cfea53f@grimberg.me

On 10/23/20 14:16, Sagi Grimberg wrote:
>> diff --git a/fabrics.c b/fabrics.c
>> index f8a055b..9c33c02 100644
>> --- a/fabrics.c
>> +++ b/fabrics.c
>> @@ -896,8 +896,6 @@ static int build_options(char *argstr, int max_len, bool discover)
>>   				cfg.keep_alive_tmo, false)) ||
>>   	    add_int_argument(&argstr, &max_len, "reconnect_delay",
>>   				cfg.reconnect_delay, false) ||
>> -	    add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
>> -				cfg.ctrl_loss_tmo, true) ||
> You just removed the entire option altogether? the user can no longer
> pass ctrl_loss_tmo now. You should instead disallow zero back (i.e.
> revert the offending patch that made it as such) and figure out
> a proper way to allow ctrl_loss_tmo=0 functionality.
>
Thanks for the comments will send out the V2.


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2020-10-26 21:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 20:25 [PATCH] nvme-cli: remove default ctrl_loss_tmo for connect Chaitanya Kulkarni
2020-10-23 21:13 ` Sagi Grimberg
2020-10-23 21:16 ` Sagi Grimberg
2020-10-26 21:02   ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB4965DB3544F102E75DE05DB486190@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).