From: Max Gurtovoy <maxg@mellanox.com>
To: Logan Gunthorpe <logang@deltatee.com>,
<linux-kernel@vger.kernel.org>, <linux-nvme@lists.infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Stephen Bates <sbates@raithlin.com>, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v10 6/9] nvme: Export existing nvme core functions
Date: Wed, 8 Jan 2020 23:48:42 +0200 [thread overview]
Message-ID: <707b39a3-b58a-44b7-7ffa-0c2bd3f28e21@mellanox.com> (raw)
In-Reply-To: <20200108174030.3430-7-logang@deltatee.com>
On 1/8/2020 7:40 PM, Logan Gunthorpe wrote:
> Export nvme_put_ns(), nvme_command_effects(), nvme_execute_passthru_rq()
> and nvme_find_get_ns() for use in the nvmet passthru code.
>
> The exports are conditional on CONFIG_NVME_TARGET_PASSTHRU.
>
> Based-on-a-patch-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> drivers/nvme/host/core.c | 14 +++++++++-----
> drivers/nvme/host/nvme.h | 5 +++++
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index d7912e7a9911..037415882d46 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -463,7 +463,7 @@ static void nvme_free_ns(struct kref *kref)
> kfree(ns);
> }
>
> -static void nvme_put_ns(struct nvme_ns *ns)
> +void nvme_put_ns(struct nvme_ns *ns)
> {
> kref_put(&ns->kref, nvme_free_ns);
> }
> @@ -896,8 +896,8 @@ static void *nvme_add_user_metadata(struct bio *bio, void __user *ubuf,
> return ERR_PTR(ret);
> }
>
> -static u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> - u8 opcode)
> +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> + u8 opcode)
> {
> u32 effects = 0;
>
> @@ -982,7 +982,7 @@ static void nvme_passthru_end(struct nvme_ctrl *ctrl, u32 effects)
> nvme_queue_scan(ctrl);
> }
>
> -static void nvme_execute_passthru_rq(struct request *rq)
> +void nvme_execute_passthru_rq(struct request *rq)
> {
> struct nvme_command *cmd = nvme_req(rq)->cmd;
> struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl;
> @@ -3441,7 +3441,7 @@ static int ns_cmp(void *priv, struct list_head *a, struct list_head *b)
> return nsa->head->ns_id - nsb->head->ns_id;
> }
>
> -static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
> +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
> {
> struct nvme_ns *ns, *ret = NULL;
>
> @@ -4225,6 +4225,10 @@ EXPORT_SYMBOL_GPL(nvme_sync_queues);
> * use by the nvmet-passthru and should not be used for
> * other things.
> */
> +EXPORT_SYMBOL_GPL(nvme_put_ns);
> +EXPORT_SYMBOL_GPL(nvme_command_effects);
> +EXPORT_SYMBOL_GPL(nvme_execute_passthru_rq);
> +EXPORT_SYMBOL_GPL(nvme_find_get_ns);
Since this is the convention in the driver, can you export the symbols
at the end of each function ?
Otherwise looks good,
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
>
> struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path)
> {
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index 356e4062796e..b1b1e7dd866b 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -687,6 +687,11 @@ static inline void nvme_hwmon_init(struct nvme_ctrl *ctrl) { }
> * use by the nvmet-passthru and should not be used for
> * other things.
> */
> +void nvme_put_ns(struct nvme_ns *ns);
> +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> + u8 opcode);
> +void nvme_execute_passthru_rq(struct request *rq);
> +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned int nsid);
> struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path);
> #endif /* CONFIG_NVME_TARGET_PASSTHRU */
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-08 21:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 17:40 [PATCH v10 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 1/9] nvme-core: Clear any SGL flags in passthru commands Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 2/9] nvme: Create helper function to obtain command effects Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 4/9] nvmet-passthru: Introduce NVMet passthru Kconfig option Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
2020-01-08 21:48 ` Max Gurtovoy [this message]
2020-01-08 21:50 ` Logan Gunthorpe
2020-01-08 22:06 ` Max Gurtovoy
2020-01-08 17:40 ` [PATCH v10 7/9] nvmet-passthru: Add passthru code to process commands Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 8/9] nvmet-passthru: Add enable/disable helpers Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 9/9] nvmet-configfs: Introduce passthru configfs interface Logan Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2019-12-12 23:54 [PATCH v10 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707b39a3-b58a-44b7-7ffa-0c2bd3f28e21@mellanox.com \
--to=maxg@mellanox.com \
--cc=axboe@fb.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).