From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v5 5/6] nvme: add csi, ms and nuse to sysfs
Date: Tue, 12 Dec 2023 05:41:06 +0000 [thread overview]
Message-ID: <7b993ee5-ad67-4df1-805c-7d4246fac18a@nvidia.com> (raw)
In-Reply-To: <20231208105337.23409-6-dwagner@suse.de>
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index d682d0a667a0..3cfae0c3af76 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -114,12 +114,97 @@ static ssize_t nsid_show(struct device *dev, struct device_attribute *attr,
> }
> static DEVICE_ATTR_RO(nsid);
>
> +static ssize_t csi_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", dev_to_ns_head(dev)->ids.csi);
> +}
> +static DEVICE_ATTR_RO(csi);
> +
> +static ssize_t metadata_bytes_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", dev_to_ns_head(dev)->ms);
> +}
> +static DEVICE_ATTR_RO(metadata_bytes);
> +
>
do we need to change the format specifier ? since csi (u8) and ms (u16)
are not declared as signed integers ...
-ck
next prev parent reply other threads:[~2023-12-12 5:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 10:53 [PATCH v5 0/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-08 10:53 ` [PATCH v5 1/6] nvme: move ns id info to struct nvme_ns_head Daniel Wagner
2023-12-11 16:27 ` Christoph Hellwig
2023-12-13 13:27 ` Sagi Grimberg
2023-12-13 14:54 ` Daniel Wagner
2023-12-13 15:38 ` Christoph Hellwig
2023-12-14 9:31 ` Daniel Wagner
2023-12-14 13:54 ` Max Gurtovoy
2023-12-08 10:53 ` [PATCH v5 2/6] nvme: refactor ns info helpers Daniel Wagner
2023-12-11 16:28 ` Christoph Hellwig
2023-12-13 13:28 ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 3/6] nvme: refactor ns info setup function Daniel Wagner
2023-12-11 16:28 ` Christoph Hellwig
2023-12-13 13:28 ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 4/6] nvme: rename ns attribute group Daniel Wagner
2023-12-13 13:32 ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 5/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-12 5:41 ` Chaitanya Kulkarni [this message]
2023-12-13 13:32 ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 6/6] nvme: repack struct nvme_ns_head Daniel Wagner
2023-12-13 13:31 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b993ee5-ad67-4df1-805c-7d4246fac18a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).