linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v5 1/6] nvme: move ns id info to struct nvme_ns_head
Date: Wed, 13 Dec 2023 15:54:25 +0100	[thread overview]
Message-ID: <7ldcd6imhzxhn3wsirhxxyhb75x5iay2p67p2i4qi2euyztc5i@nbjtvyixifqm> (raw)
In-Reply-To: <bf20cb2a-0985-467b-842b-6b5fd752f14b@grimberg.me>

On Wed, Dec 13, 2023 at 03:27:12PM +0200, Sagi Grimberg wrote:
> > @@ -841,7 +841,7 @@ static void nvme_set_ref_tag(struct nvme_ns *ns, struct nvme_command *cmnd,
> >   	u64 ref48;
> >   	/* both rw and write zeroes share the same reftag format */
> > -	switch (ns->guard_type) {
> > +	switch (ns->head->guard_type) {
> 
> I think that the whole PI stuff needs to be taken with a bit more
> consideration because if not all paths agree on the pi (as we have
> hbas with fabrics) we can't just override or do a logical or on
> the capabilities/attributes.

So should the PI variables stay in nvme_ns at this point? Or should I
add some checks which avoid an override and warn in this case?


  reply	other threads:[~2023-12-13 14:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 10:53 [PATCH v5 0/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-08 10:53 ` [PATCH v5 1/6] nvme: move ns id info to struct nvme_ns_head Daniel Wagner
2023-12-11 16:27   ` Christoph Hellwig
2023-12-13 13:27   ` Sagi Grimberg
2023-12-13 14:54     ` Daniel Wagner [this message]
2023-12-13 15:38       ` Christoph Hellwig
2023-12-14  9:31         ` Daniel Wagner
2023-12-14 13:54         ` Max Gurtovoy
2023-12-08 10:53 ` [PATCH v5 2/6] nvme: refactor ns info helpers Daniel Wagner
2023-12-11 16:28   ` Christoph Hellwig
2023-12-13 13:28   ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 3/6] nvme: refactor ns info setup function Daniel Wagner
2023-12-11 16:28   ` Christoph Hellwig
2023-12-13 13:28   ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 4/6] nvme: rename ns attribute group Daniel Wagner
2023-12-13 13:32   ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 5/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-12  5:41   ` Chaitanya Kulkarni
2023-12-13 13:32   ` Sagi Grimberg
2023-12-08 10:53 ` [PATCH v5 6/6] nvme: repack struct nvme_ns_head Daniel Wagner
2023-12-13 13:31   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ldcd6imhzxhn3wsirhxxyhb75x5iay2p67p2i4qi2euyztc5i@nbjtvyixifqm \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).