* [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs
@ 2022-09-28 9:39 Xi Ruoyao
2022-10-05 3:43 ` Chaitanya Kulkarni
2022-10-10 8:30 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Xi Ruoyao @ 2022-09-28 9:39 UTC (permalink / raw)
To: linux-nvme
Cc: linux-kernel, Christoph Hellwig, Keith Busch, Jens Axboe,
Sagi Grimberg, Ning Wang, Xi Ruoyao, Chang Feng
ZHITAI TiPro5000 SSDs has the same APST sleep problem as its cousin,
TiPro7000. The quirk for TiPro7000 has been added in
commit 6b961bce50e4 ("nvme-pci: avoid the deepest sleep state on
ZHITAI TiPro7000 SSDs"), use the same quirk for TiPro5000.
The ASPT data from "nvme id-ctrl /dev/nvme1":
vid : 0x1e49
ssvid : 0x1e49
sn : ZTA21T0KA2227304LM
mn : ZHITAI TiPlus5000 1TB
fr : ZTA09139
[...]
ps 0 : mp:6.50W operational enlat:0 exlat:0 rrt:0 rrl:0
rwt:0 rwl:0 idle_power:- active_power:-
ps 1 : mp:5.80W operational enlat:0 exlat:0 rrt:1 rrl:1
rwt:1 rwl:1 idle_power:- active_power:-
ps 2 : mp:3.60W operational enlat:0 exlat:0 rrt:2 rrl:2
rwt:2 rwl:2 idle_power:- active_power:-
ps 3 : mp:0.0500W non-operational enlat:5000 exlat:10000 rrt:3 rrl:3
rwt:3 rwl:3 idle_power:- active_power:-
ps 4 : mp:0.0025W non-operational enlat:8000 exlat:45000 rrt:4 rrl:4
rwt:4 rwl:4 idle_power:- active_power:-
Reported-and-tested-by: Chang Feng <flukehn@gmail.com>
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 98864b853eef..65481d1975cc 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3513,6 +3513,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1dbe, 0x5236), /* ADATA XPG GAMMIX S70 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1e49, 0x0021), /* ZHITAI TiPro5000 NVMe SSD */
+ .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0x1e49, 0x0041), /* ZHITAI TiPro7000 NVMe SSD */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0xc0a9, 0x540a), /* Crucial P2 */
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs
2022-09-28 9:39 [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs Xi Ruoyao
@ 2022-10-05 3:43 ` Chaitanya Kulkarni
2022-10-10 8:30 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-10-05 3:43 UTC (permalink / raw)
To: Xi Ruoyao, linux-nvme
Cc: linux-kernel, Christoph Hellwig, Keith Busch, Jens Axboe,
Sagi Grimberg, Ning Wang, Chang Feng
On 9/28/22 02:39, Xi Ruoyao wrote:
> ZHITAI TiPro5000 SSDs has the same APST sleep problem as its cousin,
> TiPro7000. The quirk for TiPro7000 has been added in
> commit 6b961bce50e4 ("nvme-pci: avoid the deepest sleep state on
> ZHITAI TiPro7000 SSDs"), use the same quirk for TiPro5000.
>
> The ASPT data from "nvme id-ctrl /dev/nvme1":
>
> vid : 0x1e49
> ssvid : 0x1e49
> sn : ZTA21T0KA2227304LM
> mn : ZHITAI TiPlus5000 1TB
> fr : ZTA09139
> [...]
> ps 0 : mp:6.50W operational enlat:0 exlat:0 rrt:0 rrl:0
> rwt:0 rwl:0 idle_power:- active_power:-
> ps 1 : mp:5.80W operational enlat:0 exlat:0 rrt:1 rrl:1
> rwt:1 rwl:1 idle_power:- active_power:-
> ps 2 : mp:3.60W operational enlat:0 exlat:0 rrt:2 rrl:2
> rwt:2 rwl:2 idle_power:- active_power:-
> ps 3 : mp:0.0500W non-operational enlat:5000 exlat:10000 rrt:3 rrl:3
> rwt:3 rwl:3 idle_power:- active_power:-
> ps 4 : mp:0.0025W non-operational enlat:8000 exlat:45000 rrt:4 rrl:4
> rwt:4 rwl:4 idle_power:- active_power:-
>
> Reported-and-tested-by: Chang Feng <flukehn@gmail.com>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs
2022-09-28 9:39 [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs Xi Ruoyao
2022-10-05 3:43 ` Chaitanya Kulkarni
@ 2022-10-10 8:30 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-10-10 8:30 UTC (permalink / raw)
To: Xi Ruoyao
Cc: linux-nvme, linux-kernel, Christoph Hellwig, Keith Busch,
Jens Axboe, Sagi Grimberg, Ning Wang, Chang Feng
Thanks,
applied to nvme-6.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-10 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 9:39 [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs Xi Ruoyao
2022-10-05 3:43 ` Chaitanya Kulkarni
2022-10-10 8:30 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).