* [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
@ 2019-09-11 16:11 Gabriel C
2019-09-11 17:19 ` Sagi Grimberg
2019-09-11 17:21 ` Sagi Grimberg
0 siblings, 2 replies; 5+ messages in thread
From: Gabriel C @ 2019-09-11 16:11 UTC (permalink / raw)
To: LKML; +Cc: Keith Busch, Jens Axboe, Christoph Hellwig, linux-nvme
Booting with default_ps_max_latency_us >6000 makes the device fail.
Also SUBNQN is NULL and gives a warning on each boot/resume.
$ nvme id-ctrl /dev/nvme0 | grep ^subnqn
subnqn : (null)
I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
To be sure is not a Laptop issue only, I tested the device on my
server board too
with the same results. ( with 2x,4x link on the motherboard and 4x on
a PCI-E card ).
Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
drivers/nvme/host/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 732d5b63ec05..627625758b40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3038,6 +3038,9 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE(0x10ec, 0x5762), /* ADATA SX6000LNP */
.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ { PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */
+ .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
+ NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.21.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
2019-09-11 16:11 [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Gabriel C
@ 2019-09-11 17:19 ` Sagi Grimberg
2019-09-11 17:21 ` Sagi Grimberg
1 sibling, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2019-09-11 17:19 UTC (permalink / raw)
To: Gabriel C, LKML; +Cc: Keith Busch, Jens Axboe, Christoph Hellwig, linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
2019-09-11 16:11 [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Gabriel C
2019-09-11 17:19 ` Sagi Grimberg
@ 2019-09-11 17:21 ` Sagi Grimberg
2019-09-11 17:39 ` Gabriel C
1 sibling, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2019-09-11 17:21 UTC (permalink / raw)
To: Gabriel C, LKML; +Cc: Keith Busch, Jens Axboe, Christoph Hellwig, linux-nvme
This does not apply on nvme-5.4, can you please respin a patch
that cleanly applies?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
2019-09-11 17:21 ` Sagi Grimberg
@ 2019-09-11 17:39 ` Gabriel C
2019-09-11 21:26 ` Gabriel C
0 siblings, 1 reply; 5+ messages in thread
From: Gabriel C @ 2019-09-11 17:39 UTC (permalink / raw)
To: Sagi Grimberg
Cc: Keith Busch, Jens Axboe, LKML, linux-nvme, Christoph Hellwig
Am Mi., 11. Sept. 2019 um 19:21 Uhr schrieb Sagi Grimberg <sagi@grimberg.me>:
>
> This does not apply on nvme-5.4, can you please respin a patch
> that cleanly applies?
Sure , just tell me from where to pull nvme-5.4 tree.
My match was against current Linus tree.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
2019-09-11 17:39 ` Gabriel C
@ 2019-09-11 21:26 ` Gabriel C
0 siblings, 0 replies; 5+ messages in thread
From: Gabriel C @ 2019-09-11 21:26 UTC (permalink / raw)
To: Sagi Grimberg
Cc: Keith Busch, Jens Axboe, LKML, linux-nvme, Christoph Hellwig
Am Mi., 11. Sept. 2019 um 19:39 Uhr schrieb Gabriel C <nix.or.die@gmail.com>:
>
> Am Mi., 11. Sept. 2019 um 19:21 Uhr schrieb Sagi Grimberg <sagi@grimberg.me>:
> >
> > This does not apply on nvme-5.4, can you please respin a patch
> > that cleanly applies?
>
> Sure , just tell me from where to pull nvme-5.4 tree.
> My match was against current Linus tree.
I send out a v2 against nvme-5.4 branch.
http://lists.infradead.org/pipermail/linux-nvme/2019-September/027144.html
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-11 21:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 16:11 [PATCH] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Gabriel C
2019-09-11 17:19 ` Sagi Grimberg
2019-09-11 17:21 ` Sagi Grimberg
2019-09-11 17:39 ` Gabriel C
2019-09-11 21:26 ` Gabriel C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).