From: "Ye, Jinhe" <jinhe.ye@intel.com>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@infradead.org>
Cc: "Zheng, Wu" <wu.zheng@intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: RE: [PATCH] nvme-pci: add another device ID with stripe quirk
Date: Wed, 17 Mar 2021 08:58:23 +0000 [thread overview]
Message-ID: <MN2PR11MB4221937A2D8E84C1BAF4D4239D6A9@MN2PR11MB4221.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210316210852.GB23332@redsun51.ssa.fujisawa.hgst.com>
Checked P5510 and it supports noiob field.
nvme id-ns /dev/nvme0n1 |grep noiob
noiob : 256
The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!
-----Original Message-----
From: Keith Busch <kbusch@kernel.org>
Sent: Wednesday, March 17, 2021 5:09 AM
To: Christoph Hellwig <hch@infradead.org>
Cc: Zheng, Wu <wu.zheng@intel.com>; linux-nvme@lists.infradead.org; Ye, Jinhe <jinhe.ye@intel.com>
Subject: Re: [PATCH] nvme-pci: add another device ID with stripe quirk
On Tue, Mar 16, 2021 at 07:30:42AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 15, 2021 at 11:22:18PM -0400, Zheng Wu wrote:
> > From: Wu Zheng <wu.zheng@intel.com>
> >
> > Adds the Intel controller of P5510 which has the "stripe" quirk.
> >
> > Signed-off-by: Zheng Wu <wu.zheng@intel.com>
> > Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
>
> I'm pretty sure we said we're not going add more of these years after
> there has been a standard way to communicate this performance
> preference using the noiob field.
P5510 was a Q4'20 release and NOIOB is 4 years older than that!
Jinhe, is it possible to reiterate to the development side how painful this non-standard behavior is to the nvme ecosystem? The spec compliant method is a simple and harmless f/w change that will make all your Linux customers better off.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-17 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 3:22 [PATCH] nvme-pci: add another device ID with stripe quirk Zheng Wu
2021-03-16 7:30 ` Christoph Hellwig
2021-03-16 21:08 ` Keith Busch
2021-03-17 8:58 ` Ye, Jinhe [this message]
2021-03-17 14:16 ` Keith Busch
2021-03-16 16:12 Zheng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4221937A2D8E84C1BAF4D4239D6A9@MN2PR11MB4221.namprd11.prod.outlook.com \
--to=jinhe.ye@intel.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wu.zheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).