* [PATCH] nvme-pci: add another device ID with stripe quirk
@ 2021-03-16 3:22 Zheng Wu
2021-03-16 7:30 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Zheng Wu @ 2021-03-16 3:22 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, Wu Zheng, Ye Jinhe
From: Wu Zheng <wu.zheng@intel.com>
Adds the Intel controller of P5510 which has the "stripe" quirk.
Signed-off-by: Zheng Wu <wu.zheng@intel.com>
Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
---
drivers/nvme/host/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7249ae7..46b872d 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3221,6 +3221,9 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_VDEVICE(INTEL, 0x0a55), /* Dell Express Flash P4600 */
.driver_data = NVME_QUIRK_STRIPE_SIZE |
NVME_QUIRK_DEALLOCATE_ZEROES, },
+ { PCI_VDEVICE(INTEL, 0x0b60), /* Intel P5510 */
+ .driver_data = NVME_QUIRK_STRIPE_SIZE |
+ NVME_QUIRK_DEALLOCATE_ZEROES, },
{ PCI_VDEVICE(INTEL, 0xf1a5), /* Intel 600P/P3100 */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
NVME_QUIRK_MEDIUM_PRIO_SQ |
--
2.7.4
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] nvme-pci: add another device ID with stripe quirk
2021-03-16 3:22 [PATCH] nvme-pci: add another device ID with stripe quirk Zheng Wu
@ 2021-03-16 7:30 ` Christoph Hellwig
2021-03-16 21:08 ` Keith Busch
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-03-16 7:30 UTC (permalink / raw)
To: Zheng Wu; +Cc: linux-nvme, kbusch, Ye Jinhe
On Mon, Mar 15, 2021 at 11:22:18PM -0400, Zheng Wu wrote:
> From: Wu Zheng <wu.zheng@intel.com>
>
> Adds the Intel controller of P5510 which has the "stripe" quirk.
>
> Signed-off-by: Zheng Wu <wu.zheng@intel.com>
> Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
I'm pretty sure we said we're not going add more of these years after
there has been a standard way to communicate this performance preference
using the noiob field.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: add another device ID with stripe quirk
2021-03-16 7:30 ` Christoph Hellwig
@ 2021-03-16 21:08 ` Keith Busch
2021-03-17 8:58 ` Ye, Jinhe
0 siblings, 1 reply; 6+ messages in thread
From: Keith Busch @ 2021-03-16 21:08 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Zheng Wu, linux-nvme, Ye Jinhe
On Tue, Mar 16, 2021 at 07:30:42AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 15, 2021 at 11:22:18PM -0400, Zheng Wu wrote:
> > From: Wu Zheng <wu.zheng@intel.com>
> >
> > Adds the Intel controller of P5510 which has the "stripe" quirk.
> >
> > Signed-off-by: Zheng Wu <wu.zheng@intel.com>
> > Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
>
> I'm pretty sure we said we're not going add more of these years after
> there has been a standard way to communicate this performance preference
> using the noiob field.
P5510 was a Q4'20 release and NOIOB is 4 years older than that!
Jinhe, is it possible to reiterate to the development side how painful
this non-standard behavior is to the nvme ecosystem? The spec compliant
method is a simple and harmless f/w change that will make all your Linux
customers better off.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] nvme-pci: add another device ID with stripe quirk
2021-03-16 21:08 ` Keith Busch
@ 2021-03-17 8:58 ` Ye, Jinhe
2021-03-17 14:16 ` Keith Busch
0 siblings, 1 reply; 6+ messages in thread
From: Ye, Jinhe @ 2021-03-17 8:58 UTC (permalink / raw)
To: Keith Busch, Christoph Hellwig; +Cc: Zheng, Wu, linux-nvme
Checked P5510 and it supports noiob field.
nvme id-ns /dev/nvme0n1 |grep noiob
noiob : 256
The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!
-----Original Message-----
From: Keith Busch <kbusch@kernel.org>
Sent: Wednesday, March 17, 2021 5:09 AM
To: Christoph Hellwig <hch@infradead.org>
Cc: Zheng, Wu <wu.zheng@intel.com>; linux-nvme@lists.infradead.org; Ye, Jinhe <jinhe.ye@intel.com>
Subject: Re: [PATCH] nvme-pci: add another device ID with stripe quirk
On Tue, Mar 16, 2021 at 07:30:42AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 15, 2021 at 11:22:18PM -0400, Zheng Wu wrote:
> > From: Wu Zheng <wu.zheng@intel.com>
> >
> > Adds the Intel controller of P5510 which has the "stripe" quirk.
> >
> > Signed-off-by: Zheng Wu <wu.zheng@intel.com>
> > Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
>
> I'm pretty sure we said we're not going add more of these years after
> there has been a standard way to communicate this performance
> preference using the noiob field.
P5510 was a Q4'20 release and NOIOB is 4 years older than that!
Jinhe, is it possible to reiterate to the development side how painful this non-standard behavior is to the nvme ecosystem? The spec compliant method is a simple and harmless f/w change that will make all your Linux customers better off.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: add another device ID with stripe quirk
2021-03-17 8:58 ` Ye, Jinhe
@ 2021-03-17 14:16 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-03-17 14:16 UTC (permalink / raw)
To: Ye, Jinhe; +Cc: Christoph Hellwig, Zheng, Wu, linux-nvme
On Wed, Mar 17, 2021 at 08:58:23AM +0000, Ye, Jinhe wrote:
> Checked P5510 and it supports noiob field.
> nvme id-ns /dev/nvme0n1 |grep noiob
> noiob : 256
Awesome! So you don't need the quirk. :)
> The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!
Linux initially supported noiob since v4.13, which was released 9/2017.
If you need to go older than that, I think backporting noiob support
is a better option adding more quirks.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme-pci: add another device ID with stripe quirk
@ 2021-03-16 16:12 Zheng Wu
0 siblings, 0 replies; 6+ messages in thread
From: Zheng Wu @ 2021-03-16 16:12 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, Wu Zheng, Ye Jinhe
From: Wu Zheng <wu.zheng@intel.com>
Adds the Intel controller of P5510 which has the "stripe" quirk.
Signed-off-by: Zheng Wu <wu.zheng@intel.com>
Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>
---
drivers/nvme/host/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7249ae7..46b872d 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3221,6 +3221,9 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_VDEVICE(INTEL, 0x0a55), /* Dell Express Flash P4600 */
.driver_data = NVME_QUIRK_STRIPE_SIZE |
NVME_QUIRK_DEALLOCATE_ZEROES, },
+ { PCI_VDEVICE(INTEL, 0x0b60), /* Intel P5510 */
+ .driver_data = NVME_QUIRK_STRIPE_SIZE |
+ NVME_QUIRK_DEALLOCATE_ZEROES, },
{ PCI_VDEVICE(INTEL, 0xf1a5), /* Intel 600P/P3100 */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
NVME_QUIRK_MEDIUM_PRIO_SQ |
--
2.7.4
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-17 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 3:22 [PATCH] nvme-pci: add another device ID with stripe quirk Zheng Wu
2021-03-16 7:30 ` Christoph Hellwig
2021-03-16 21:08 ` Keith Busch
2021-03-17 8:58 ` Ye, Jinhe
2021-03-17 14:16 ` Keith Busch
2021-03-16 16:12 Zheng Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).